Skip to content

dotnet-dump and dotnet-symbol returns 407 behind a proxy #5478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

dotnet-dump and dotnet-symbol returns 407 behind a proxy #5478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ca092a
dotnet-dump and dotnet-symbol returns 407 behind a proxy when downloa…
May 8, 2025
c9cb4c9
Custom new HttpClientHandler() when HttpSymbolServer is built on .net…
May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Microsoft.SymbolStore/SymbolStores/HttpSymbolStore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,15 @@ public HttpSymbolStore(ITracer tracer, SymbolStore backingStore, Uri symbolServe
_authenticationFunc = authenticationFunc;

// Create client
_client = new HttpClient
#if NETSTANDARD2_0
Copy link
Author

@ladeak ladeak May 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is enough, but I can only fully test it on Monday.

Ref:
https://learn.microsoft.com/en-us/dotnet/api/system.net.http.httpclienthandler.defaultproxycredentials?view=netstandard-2.0#system-net-http-httpclienthandler-defaultproxycredentials

and

https://learn.microsoft.com/en-us/dotnet/api/system.net.http.httpclienthandler.usedefaultcredentials?view=netstandard-2.0

Proxy is left default, UseProxy is set to true, DefaultProxyCredentials set.

EDIT I find this change more risky. HttpClientHandler has different behavior on .net462, .net8, .net9.

_client = new HttpClient(new HttpClientHandler()
{
UseProxy = true,
DefaultProxyCredentials = CredentialCache.DefaultNetworkCredentials,
})
#else
_client = new HttpClient()
#endif
{
Timeout = TimeSpan.FromMinutes(4)
};
Expand Down
1 change: 0 additions & 1 deletion src/Tools/dotnet-dump/Analyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
using System.Runtime.InteropServices;
using System.Security;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Diagnostics.DebugServices;
using Microsoft.Diagnostics.DebugServices.Implementation;
using Microsoft.Diagnostics.ExtensionCommands;
Expand Down
5 changes: 2 additions & 3 deletions src/Tools/dotnet-symbol/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public static void Main(string[] args)
program.SymbolServers.Add(new ServerInfo { Uri = uri, PersonalAccessToken = null });
break;

case "--internal-server":
case "--internal-server":
Uri.TryCreate("https://symweb.azurefd.net/", UriKind.Absolute, out uri);
program.SymbolServers.Add(new ServerInfo { Uri = uri, PersonalAccessToken = null, InternalSymwebServer = true });
break;
Expand Down Expand Up @@ -597,8 +597,7 @@ internal void VerifyCoreDump()

private IEnumerable<string> GetInputFiles()
{
IEnumerable<string> inputFiles = InputFilePaths.SelectMany((string file) =>
{
IEnumerable<string> inputFiles = InputFilePaths.SelectMany((string file) => {
string directory = Path.GetDirectoryName(file);
string pattern = Path.GetFileName(file);
return Directory.EnumerateFiles(string.IsNullOrWhiteSpace(directory) ? "." : directory, pattern,
Expand Down