Skip to content

Fix DiagnosticsClient.WriteDump to handle dump paths with spaces on Windows #5593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix DiagnosticsClient.WriteDump to handle dump paths with spaces on Windows #5593

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
620956f
Initial plan
Copilot Oct 8, 2025
0f362f4
Fix dump path with spaces by quoting the path
Copilot Oct 8, 2025
c9e0f77
Improve fix to avoid double-quoting already quoted paths
Copilot Oct 8, 2025
51601ce
Restrict path quoting to Windows only
Copilot Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/DiagnosticsClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,15 @@ private static IpcMessage CreateWriteDumpMessage(DumpType dumpType, string dumpP
throw new ArgumentNullException($"{nameof(dumpPath)} required");
}

byte[] payload = SerializePayload(dumpPath, (uint)dumpType, logDumpGeneration);
// Quote the path to handle spaces correctly in createdump on Windows only
// Only add quotes if the path is not already quoted
// This is only needed on Windows where the runtime builds the command line for createdump
string pathToUse = dumpPath;
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
pathToUse = dumpPath.StartsWith("\"") && dumpPath.EndsWith("\"") ? dumpPath : $"\"{dumpPath}\"";
}
byte[] payload = SerializePayload(pathToUse, (uint)dumpType, logDumpGeneration);
return new IpcMessage(DiagnosticsServerCommandSet.Dump, (byte)DumpCommandId.GenerateCoreDump, payload);
}

Expand All @@ -709,7 +717,15 @@ private static IpcMessage CreateWriteDumpMessage(DumpCommandId command, DumpType
throw new ArgumentNullException($"{nameof(dumpPath)} required");
}

byte[] payload = SerializePayload(dumpPath, (uint)dumpType, (uint)flags);
// Quote the path to handle spaces correctly in createdump on Windows only
// Only add quotes if the path is not already quoted
// This is only needed on Windows where the runtime builds the command line for createdump
string pathToUse = dumpPath;
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
pathToUse = dumpPath.StartsWith("\"") && dumpPath.EndsWith("\"") ? dumpPath : $"\"{dumpPath}\"";
}
byte[] payload = SerializePayload(pathToUse, (uint)dumpType, (uint)flags);
return new IpcMessage(DiagnosticsServerCommandSet.Dump, (byte)command, payload);
}

Expand Down