chore: Remove code that create unused docfx temp directory#10463
Merged
yufeih merged 1 commit intodotnet:mainfrom Dec 24, 2024
Merged
chore: Remove code that create unused docfx temp directory#10463yufeih merged 1 commit intodotnet:mainfrom
yufeih merged 1 commit intodotnet:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10463 +/- ##
==========================================
+ Coverage 74.31% 79.40% +5.08%
==========================================
Files 536 547 +11
Lines 23189 23621 +432
Branches 4056 4061 +5
==========================================
+ Hits 17234 18756 +1522
+ Misses 4853 3695 -1158
- Partials 1102 1170 +68 ☔ View full report in Codecov by Sentry. |
yufeih
approved these changes
Dec 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intended to remove extra file I/O.
Background
Currently
docfx pdfcommand create temp directory (%Temp%\.docfx\pdf\pages)But this temp directory seems not be used. (On current implementation/ All PDF page bytes are processed on memory)
Related code is removed at this commit