Misc PackageIndexer updates #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gewarren
commented
Sep 18, 2024
gewarren
commented
- Hardcode list of .NET packages (this is temporary - eventually will query Kusto)
- Don't include XML file for Microsoft.Extensions.Diagnostics.ResourceMonitoring (see .NET 9 RC 1 updates dotnet-api-docs#10395 (comment))
BillWagner
approved these changes
Sep 19, 2024
| // TODO - this URL is no longer accessible. | ||
| string url = "https://nugetprodusncazuresearch.blob.core.windows.net/v3-azuresearch-017/owners/owners.v2.json"; | ||
| return httpClient.GetFromJsonAsync<Dictionary<string, string[]>>(url); | ||
| return httpClient.GetFromJsonAsync<Dictionary<string, string[]>>(url)!; |
There was a problem hiding this comment.
Should this throw an exception if the result is null?
There was a problem hiding this comment.
I logged #411 since this merged already. Thanks for the review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.