-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Document default 75% value for GCHeapHardLimitPercent in container environments #50280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…vironments Co-authored-by: agocke <[email protected]>
|
@copilot I believe this would read better as: |
|
@copilot I believe this would read better as: |
Co-authored-by: agocke <[email protected]>
agocke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot please address
|
|
||
| - The heap hard limit is defined as the maximum commit size, in bytes, for the GC heap and GC bookkeeping. | ||
| - This setting only applies to 64-bit computers. | ||
| - If this limit isn't configured but the process is running in a memory-constrained environment, that is, inside a container with a specified memory limit, a default value is set. That default is the greater of 20 MB or 75% of the memory limit on the container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually not sure this is correct. If this were true, then setting GCHeapHardLimitPercent to, say, 90% inside of a container would be equal to .75 * .9 * x = .675x, but it's actually .9x. I think we should instead note that inside a container the GCHeaphardLimitPercent has a different default value (and point to that section)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated line 303 to reference the heap hard limit percent section instead of duplicating the 75% value. This centralizes the default value documentation in GCHeapHardLimitPercent and clarifies the relationship. Commit d6dd0eb.
… duplicating Co-authored-by: agocke <[email protected]>
Summary
Updated the garbage collector documentation to properly document the default 75% memory limit behavior in container environments:
This centralizes the default percentage documentation in one place (
GCHeapHardLimitPercent) and references it from theGCHeapHardLimitsection, avoiding potential confusion about how the values interact.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Internal previews