Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 2, 2025

Summary

The GCHeapHardLimit section documents that containers default to "75% of the memory limit" but this information was missing from GCHeapHardLimitPercent. Updated the first bullet point in the "Heap hard limit percent" section to:

  • Clarify that in memory-constrained environments (containers), the container limit is considered the total physical memory
  • Document that the default value is 75% when running in memory-constrained environments
Original prompt

This line

If this limit isn't configured but the process is running in a memory-constrained environment, that is, inside a container with a specified memory limit, a default value is set. That default is the greater of 20 MB or 75% of the memory limit on the container.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Set default memory limit for constrained environments Document default 75% value for GCHeapHardLimitPercent in container environments Dec 2, 2025
Copilot AI requested a review from agocke December 2, 2025 23:45
Copilot finished work on behalf of agocke December 2, 2025 23:45
@agocke
Copy link
Member

agocke commented Dec 2, 2025

@copilot I believe this would read better as:
Specifies the heap hard limit as a percentage of the total physical memory. If the process is running in a memory-constrained environment, that is, inside a container with a specified memory limit, the total physical memory is the memory limit; otherwise it's what's available on the machine.

@agocke
Copy link
Member

agocke commented Dec 2, 2025

@copilot I believe this would read better as:
Specifies the heap hard limit as a percentage of the total physical memory. If the process is running in a memory-constrained environment, that is, inside a container with a specified memory limit, the container limit is considered the total physical memory. If in a memory-constrained environment, the default value is 75%.

Copy link
Contributor Author

Copilot AI commented Dec 2, 2025

@copilot I believe this would read better as:
Specifies the heap hard limit as a percentage of the total physical memory. If the process is running in a memory-constrained environment, that is, inside...

Updated the wording as suggested in commit f552eb5.

Copilot finished work on behalf of agocke December 2, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants