Revisions for Reiwa era #11611
Merged
Revisions for Reiwa era #11611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarekgh
approved these changes
Apr 1, 2019
|
@rpetrusha the changes here looks good to me. I have a couple of questions/points:
Thanks |
mairaw
approved these changes
Apr 1, 2019
| @@ -199,7 +202,7 @@ In specifying a era to the <xref:System.Globalization.Calendar.ToDateTime(System | |||
|
|
|||
| ### Calendars, eras, and date ranges: Relaxed range checks | |||
|
|
|||
| Very much like individual calendars have supported date ranges, eras in the <xref:System.Globalization.JapaneseCalendar> and <xref:System.Globalization.JapaneseLunisolarCalendar> classes also have supported ranges. Previously, .NET used strict era range checks to ensure that a era-specific date was within the range of that era. An out-of-range date would throw a the .NET Framework uses relaxed ranged checking by default. That is, if a date is outside of the range of the specified era, the method throws an <xref:System.ArgumentOutOfRangeException>. Updates to all versions of the .NET Framework introduced relaxed era range checks; the attempt to instantiate an era-specific date that is outside the range of the specified era "overflow" into the following era, and no exception is thrown. | |||
| Very much like individual calendars have supported date ranges, eras in the <xref:System.Globalization.JapaneseCalendar> and <xref:System.Globalization.JapaneseLunisolarCalendar> classes also have supported ranges. Previously, .NET used strict era range checks to ensure that an era-specific date was within the range of that era. That is, if a date is outside of the range of the specified era, the method throws an <xref:System.ArgumentOutOfRangeException>. Currently, the .NET Framework uses relaxed ranged checking by default. Updates to all versions of the .NET Framework introduced relaxed era range checks; the attempt to instantiate an era-specific date that is outside the range of the specified era "overflows" into the following era, and no exception is thrown. | |||
There was a problem hiding this comment.
you mention Framework here, but what about Core?
|
@tarekgh, I'll update the blog either later today or first thing tomorrow morning. Also, the list of era names is in the documentation for the JapaneseCalendar and JapaneseLunisolarCalendar classes; I've just opened dotnet/dotnet-api-docs#2224 to revise the documentation for the Reiwa era. |
Accepted Maira's suggestions. Co-Authored-By: rpetrusha <[email protected]>
|
Closing and reopening to begin new build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisions for Reiwa era
Describe your changes here.
Fixes #11610
@tarekgh