fix: MD007/ul-indent #11783
fix: MD007/ul-indent #11783
Conversation
nschonni
commented
Apr 11, 2019
nschonni
commented
- Unordered list indentation
- Added code fence languages
- Trim trailing/leading spaces
nschonni
requested review from
BillWagner,
Lxiamail,
rpetrusha and
stevestein
as code owners
nschonni
force-pushed
the
fix--MD007/ul-indent2
branch
from
d4b4fe2 to
b8923e7
Compare
|
|
||
| To provide the [!INCLUDE[ssAstoria](../../../../includes/ssastoria-md.md)] runtime with access to the <xref:System.Data.Services.Providers.IDataServiceStreamProvider> implementation, the data service that you create must also implement the <xref:System.IServiceProvider> interface. The following example shows how to implement the <xref:System.IServiceProvider.GetService%2A> method to return an instance of the `PhotoServiceStreamProvider` class that implements <xref:System.Data.Services.Providers.IDataServiceStreamProvider>. | ||
|
|
||
| [!code-csharp[Astoria Photo Streaming Service#PhotoServiceStreamingProvider](../../../../samples/snippets/csharp/VS_Snippets_Misc/astoria%20photo%20streaming%20service/cs/photodata.svc.cs#photoservicestreamingprovider)] |
There was a problem hiding this comment.
I'm a bit confused. Shouldn't the space characters change to _ to match dotnet/samples#810?
And, that begs the question: will other docs need to be updated for those folder and file name changes?
There was a problem hiding this comment.
I just saw #11784
If I understand correctly, we should merge this in the following order:
#11783
dotnet/samples#810
#11784
Does that make sense @nschonni ?
There was a problem hiding this comment.
Thanks, I thought I had undone all of these to handle them separately. I've rebased these ones out so those other PRs should be independent again
nschonni
force-pushed
the
fix--MD007/ul-indent2
branch
3 times, most recently
from
e74fb07 to
3171cc7
Compare
- Unordered list indentation - Added code fence languages - Trim trailing/leading spaces
nschonni
force-pushed
the
fix--MD007/ul-indent2
branch
from
3171cc7 to
f253e2c
Compare
|
@BillWagner I've rebased this now that the other PRs landed |
|
@BillWagner anything to change here? |
|
@nschonni Thanks for the ping. I was OOF for a long weekend, and this dropped off my radar. Reviewing now. |
There was a problem hiding this comment.
Thanks again for all the work @nschonni
This is great. I'll 
now.
|
@BillWagner not a problem |
2 participants
