Skip to content

Conversation

@BillWagner
Copy link
Member

@BillWagner BillWagner commented Aug 14, 2024

Contributes to #41572

All lot of the updates are small. It may be easier to review commit-by-commit.


Internal previews

Toggle expand/collapse
📄 File 🔗 Preview link
docs/csharp/advanced-topics/expression-trees/index.md docs/csharp/advanced-topics/expression-trees/index
docs/csharp/advanced-topics/reflection-and-attributes/index.md docs/csharp/advanced-topics/reflection-and-attributes/index
docs/csharp/event-pattern.md docs/csharp/event-pattern
docs/csharp/fundamentals/exceptions/how-to-handle-an-exception-using-try-catch.md docs/csharp/fundamentals/exceptions/how-to-handle-an-exception-using-try-catch
docs/csharp/fundamentals/types/classes.md docs/csharp/fundamentals/types/classes
docs/csharp/fundamentals/types/index.md docs/csharp/fundamentals/types/index
docs/csharp/language-reference/compiler-messages/cs8795.md docs/csharp/language-reference/compiler-messages/cs8795
docs/csharp/language-reference/compiler-messages/expression-tree-restrictions.md docs/csharp/language-reference/compiler-messages/expression-tree-restrictions
docs/csharp/language-reference/compiler-messages/inline-array-errors.md docs/csharp/language-reference/compiler-messages/inline-array-errors
docs/csharp/language-reference/keywords/from-clause.md docs/csharp/language-reference/keywords/from-clause
docs/csharp/language-reference/keywords/get.md docs/csharp/language-reference/keywords/get
docs/csharp/language-reference/keywords/index.md docs/csharp/language-reference/keywords/index
docs/csharp/language-reference/keywords/partial-type.md docs/csharp/language-reference/keywords/partial-type
docs/csharp/language-reference/keywords/select-clause.md docs/csharp/language-reference/keywords/select-clause
docs/csharp/language-reference/keywords/set.md docs/csharp/language-reference/keywords/set
docs/csharp/language-reference/xmldoc/recommended-tags.md docs/csharp/language-reference/xmldoc/recommended-tags
docs/csharp/misc/cs0501.md docs/csharp/misc/cs0501
docs/csharp/misc/cs0751.md docs/csharp/misc/cs0751
docs/csharp/programming-guide/classes-and-structs/access-modifiers.md docs/csharp/programming-guide/classes-and-structs/access-modifiers
docs/csharp/programming-guide/classes-and-structs/auto-implemented-properties.md docs/csharp/programming-guide/classes-and-structs/auto-implemented-properties
docs/csharp/programming-guide/classes-and-structs/interface-properties.md docs/csharp/programming-guide/classes-and-structs/interface-properties
docs/csharp/programming-guide/classes-and-structs/partial-classes-and-methods.md docs/csharp/programming-guide/classes-and-structs/partial-classes-and-methods
docs/csharp/programming-guide/classes-and-structs/properties.md docs/csharp/programming-guide/classes-and-structs/properties
docs/csharp/programming-guide/classes-and-structs/using-properties.md docs/csharp/programming-guide/classes-and-structs/using-properties
docs/csharp/programming-guide/indexers/index.md docs/csharp/programming-guide/indexers/index
docs/csharp/programming-guide/indexers/indexers-in-interfaces.md docs/csharp/programming-guide/indexers/indexers-in-interfaces
docs/csharp/programming-guide/indexers/using-indexers.md docs/csharp/programming-guide/indexers/using-indexers
docs/csharp/tour-of-csharp/tips-for-java-developers.md docs/csharp/tour-of-csharp/tips-for-java-developers
docs/csharp/whats-new/csharp-13.md docs/csharp/whats-new/csharp-13
docs/csharp/whats-new/csharp-version-history.md docs/csharp/whats-new/csharp-version-history

Note

This table shows preview links for the 30 files with the most changes. For preview links for other files in this PR, select OpenPublishing.Build Details within checks.

Now that `partial` can be used for properties and indexers as well, the name "partial member" is better.
Add the feature spec to the learn platform.
- Update the partial members article to include details for partial properties. This includes new information that also applies to partial methods.
- Update the partial types article to include that partial members can now include properties and indexers.
Update language reference with links

Add links or text on partial properties and indexers in the language reference.
These articles mention partial types. Make necessary updates, clear open issues on these articles.
@dotnet-policy-service dotnet-policy-service bot added the okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. label Aug 15, 2024
@BillWagner
Copy link
Member Author

The snippets 5000 error is a false positive. This PR moves samples from locations without a project to a location that has a project to compile.

@dotnet-policy-service dotnet-policy-service bot added the okr-curation OKR: Curate content to remove outdated recommendations label Aug 15, 2024
@BillWagner BillWagner force-pushed the partial-properties branch 2 times, most recently from 8175058 to f1ea86f Compare August 16, 2024 12:56
The introductory articles for properties and indexers were largely duplicated, combine them.
Fix all open issues on the the combined articles.
Also, remove unsed snippets
Edit and freshness pass on the combined indexers article.
@BillWagner BillWagner marked this pull request as ready for review August 20, 2024 16:32
@BillWagner BillWagner requested review from a team and IEvangelist as code owners August 20, 2024 16:32
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had one suggestion.

@BillWagner BillWagner merged commit 985d4e9 into dotnet:main Aug 22, 2024
@BillWagner BillWagner deleted the partial-properties branch August 22, 2024 14:38
@BillWagner BillWagner added the 🏁 Release: .NET 9 Work items for the .NET 9 release label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏁 Release: .NET 9 Work items for the .NET 9 release okr-curation OKR: Curate content to remove outdated recommendations okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.

Projects

None yet

2 participants