Skip to content

EnumConverter breaking change #42847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 31, 2024
Merged

EnumConverter breaking change #42847

merged 5 commits into from
Oct 31, 2024

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented Oct 4, 2024 •
edited
Loading

@gewarren gewarren requested a review from LakshanF October 4, 2024 21:13
@gewarren gewarren requested a review from a team as a code owner October 4, 2024 21:13
gewarren
gewarren commented Oct 4, 2024
View reviewed changes
@gewarren
Copy link
Contributor Author

gewarren commented Oct 23, 2024

@LakshanF Can you review this when you get a chance?

@LakshanF LakshanF requested a review from ericstj October 28, 2024 16:52
LakshanF
LakshanF approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@LakshanF LakshanF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it will be great if @ericstj can also take a look at this.

@ericstj ericstj requested a review from steveharter October 29, 2024 17:36
@gewarren gewarren merged commit f21aff3 into dotnet:main Oct 31, 2024
9 checks passed
@gewarren gewarren deleted the enumconverter branch October 31, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericstj ericstj Awaiting requested review from ericstj

@steveharter steveharter Awaiting requested review from steveharter

1 more reviewer

@LakshanF LakshanF LakshanF approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Breaking change]: EnumConverter validates registered types to be enum

3 participants

@gewarren @LakshanF @ericstj