Skip to content

Conversation

@0101
Copy link
Contributor

@0101 0101 commented Oct 30, 2024

@0101 0101 requested review from a team, BillWagner and KathleenDollard as code owners October 30, 2024 16:14
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just maybe align the headers a bit more in terms of sentence structure.

E.g.: Nullable reference types x Support for empty-bodied computation expressions

Pick one of:

  • Nullable reference types x Empty-bodied computation expressions
  • Support for nullable reference types x Support for empty-bodied computation expressions

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @0101

I had some suggestions to consider, and then it's ready to merge.

@0101 0101 merged commit 30839a4 into dotnet:main Nov 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants