Skip to content

Add System.Diagnostics.DiagnosticSource netstandard guidance #43269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 1, 2024
Merged

Add System.Diagnostics.DiagnosticSource netstandard guidance #43269

merged 4 commits into from
Nov 1, 2024

Conversation

@noahfalk
Copy link
Member

@noahfalk noahfalk commented Oct 31, 2024 •
edited by github-actions bot
Loading

Updating the guidance to clarify that this is also relevant for authors of netstandard libraries.

Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs.md docs/core/diagnostics/distributed-tracing-instrumentation-walkthroughs

@noahfalk noahfalk requested review from a team and tommcdon as code owners October 31, 2024 20:36
@dotnetrepoman dotnetrepoman bot added this to the October 2024 milestone Oct 31, 2024
eerhardt
eerhardt reviewed Oct 31, 2024
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this up.

@noahfalk noahfalk merged commit 09bfdc7 into main Nov 1, 2024
8 checks passed
@noahfalk noahfalk deleted the noahfalk-patch-1 branch November 1, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eerhardt eerhardt eerhardt left review comments

@tarekgh tarekgh tarekgh approved these changes

@tommcdon tommcdon Awaiting requested review from tommcdon tommcdon is a code owner

Assignees

No one assigned

Labels

dotnet-fundamentals/svc

Projects

None yet

Milestone

October 2024

Development

Successfully merging this pull request may close these issues.

4 participants

@noahfalk @eerhardt @tarekgh