Skip to content

Update MSTEST0006 docs now that there is a codefix #43403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2024
Merged

Update MSTEST0006 docs now that there is a codefix #43403

merged 2 commits into from
Nov 16, 2024

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Nov 11, 2024 •
edited by github-actions bot
Loading

Product PR: microsoft/testfx#4038

The product PR needs to be merged first

Internal previews

📄 File 🔗 Preview link
docs/core/testing/mstest-analyzers/mstest0006.md MSTEST0006: Avoid [ExpectedException]

@Youssef1313 Youssef1313 requested review from a team and IEvangelist as code owners November 11, 2024 16:24
@Youssef1313 Youssef1313 marked this pull request as draft November 11, 2024 16:24
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Nov 11, 2024
@gewarren gewarren added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Nov 11, 2024
gewarren
gewarren reviewed Nov 11, 2024
View reviewed changes
Youssef1313
Youssef1313 commented Nov 11, 2024
View reviewed changes
@Youssef1313 Youssef1313 marked this pull request as ready for review November 12, 2024 08:19
@Youssef1313
Copy link
Member Author

Youssef1313 commented Nov 12, 2024

@gewarren This should be ready now. cc @Evangelink

@Evangelink
Copy link
Member

Evangelink commented Nov 12, 2024

@gewarren FYI @Youssef1313 is no longer community contributor, he is now part of the team :)

@gewarren
Copy link
Contributor

gewarren commented Nov 12, 2024

@gewarren FYI @Youssef1313 is no longer community contributor, he is now part of the team :)

What?? That's the best news I've heard in years...seriously.

@adegeo
Copy link
Contributor

adegeo commented Nov 12, 2024

@gewarren FYI @Youssef1313 is no longer community contributor, he is now part of the team :)

AWESOME!

@BillWagner
Copy link
Member

BillWagner commented Nov 12, 2024

@gewarren FYI @Youssef1313 is no longer community contributor, he is now part of the team :)

This is great news! Glad to see you join the team @Youssef1313

@Evangelink
Copy link
Member

Evangelink commented Nov 12, 2024

@gewarren FYI @Youssef1313 is no longer community contributor, he is now part of the team :)

What?? That's the best news I've heard in years...seriously.

Right after me being hired, right ;)

@Evangelink Evangelink removed 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) community-contribution Indicates PR is created by someone from the .NET community. labels Nov 12, 2024
@gewarren
Copy link
Contributor

gewarren commented Nov 12, 2024

Right after me being hired, right ;)

Right, yes.

@Evangelink
Copy link
Member

Evangelink commented Nov 16, 2024

@gewarren are we waiting for @IEvangelist or can we merge?

@gewarren gewarren merged commit 914901c into dotnet:main Nov 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gewarren gewarren gewarren approved these changes

@Evangelink Evangelink Evangelink approved these changes

@IEvangelist IEvangelist Awaiting requested review from IEvangelist IEvangelist is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Youssef1313 @Evangelink @gewarren @adegeo @BillWagner