Skip to content

Conversation

@marcpopMSFT
Copy link
Member

@marcpopMSFT marcpopMSFT commented Nov 13, 2024

Summary

See this customer comment here:
https://developercommunity.visualstudio.com/t/https:learnmicrosoftcomen-usdotnet/10787012
https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/implicit-global-using-netfx

I'm not sure how important it is to include the breaking change in the primary documentation so I'll defer to the doc folks but putting this PR out as a proposal.


Internal previews

📄 File 🔗 Preview link
docs/core/project-sdk/overview.md .NET project SDKs

@marcpopMSFT marcpopMSFT requested review from a team and gewarren as code owners November 13, 2024 21:47
@dotnetrepoman dotnetrepoman bot added this to the November 2024 milestone Nov 13, 2024
@gewarren
Copy link
Contributor

Since .NET 6/7 are no longer supported, it might just be better to remove System.Net.Http from line 132 and 136.

@marcpopMSFT
Copy link
Member Author

Since .NET 6/7 are no longer supported, it might just be better to remove System.Net.Http from line 132 and 136.

@gewarren the nuance here is that in the .NET 8 SDK, System.Net.Http was removed from .NET Framework targeting (eg. net472 targeting). It's still included if you target net8.0 or net9.0. I wasn't sure the best way to include that distinction in the documentation.

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@gewarren gewarren enabled auto-merge (squash) November 15, 2024 18:51
@gewarren gewarren merged commit bcec628 into main Nov 15, 2024
8 checks passed
@gewarren gewarren deleted the marcpopMSFT-patch-1 branch November 15, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants