Skip to content

Fixed wordings in access-control doc for F#. #43965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shethaadit wants to merge 1 commit into from
Closed

Fixed wordings in access-control doc for F#. #43965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/fsharp/language-reference/access-control.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ In F#, the access control specifiers `public`, `internal`, and `private` can be

The access specifier is put in front of the name of the entity.

If no access specifier is used, the default is `public`, except for `let` bindings in a type, which are always `private` to the type.
If no access specifier is used, the default is `public`, except for `let` bindings in a type or a function, which are always `private` to the type.
Copy link
Member

@T-Gro T-Gro Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let bindings inside a function will often become just stack values, which do not have any access modifier.
I would rather keep the original phrasing as it was.

If you want to expand on "functions declared within other functions", it should be its own sentence.

Copy link
Contributor Author

@shethaadit shethaadit Jan 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @psfinaki, could you please provide your inputs so we can close this?

Copy link
Contributor

@psfinaki psfinaki Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shethaadit I agree with the above. I approved the PR because it makes the docs better anyway but the @T-Gro's inputs are valid so if it's not much effort for you, I would also appreciate if you address those.

Sorry for this taking long, Xmas came in sight, hope we'll progress with this quickly now.

Thanks for your continuous efforts around F# docs!


Signatures in F# provide another mechanism for controlling access to F# program elements. Signatures are not required for access control. For more information, see [Signatures](signature-files.md).

Expand Down
Loading