Extend the NRBF docs and focus on safety #44214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…afe to call BinaryFormatter
… things like unbound recursion
…dId to detect these, extend one of the samples with simple cycle detection
…lso show that users need to be defensive and reject records of unexpected types
gewarren
approved these changes
Jan 10, 2025
Contributor
gewarren
left a comment
gewarren
left a comment
There was a problem hiding this comment.
Thank you. I left some suggestions to consider.
docs/standard/serialization/binaryformatter-migration-guide/read-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/read-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/read-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/read-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/read-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/read-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <[email protected]>
…ad-nrbf-payloads.md Co-authored-by: Genevieve Warren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal previews