Skip to content

EventsThreadShutdown obsoletion #44287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gewarren merged 3 commits into from
Jan 17, 2025
Merged

EventsThreadShutdown obsoletion #44287

gewarren merged 3 commits into from
Jan 17, 2025

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented Jan 14, 2025 •
edited by github-actions bot
Loading

Fixes #43563

Internal previews

📄 File 🔗 Preview link
docs/core/compatibility/10.0.md Breaking changes in .NET 10
docs/core/compatibility/core-libraries/10.0/obsolete-apis.md API obsoletions with non-default diagnostic IDs (.NET 10)
docs/core/compatibility/core-libraries/8.0/obsolete-apis-with-custom-diagnostics.md "Breaking change: .NET 8 obsoletions with custom IDs"
docs/core/compatibility/core-libraries/9.0/obsolete-apis-with-custom-diagnostics.md API obsoletions with non-default diagnostic IDs (.NET 9)
docs/core/compatibility/toc.yml docs/core/compatibility/toc
docs/fundamentals/syslib-diagnostics/obsoletions-overview.md Obsolete features in .NET 5+
docs/fundamentals/syslib-diagnostics/syslib0059.md SYSLIB0059: SystemEvents.EventsThreadShutdown callbacks aren't run before the process exits
docs/navigate/tools-diagnostics/toc.yml docs/navigate/tools-diagnostics/toc

@gewarren gewarren requested review from a team and CamSoper as code owners January 14, 2025 23:25
@dotnetrepoman dotnetrepoman bot added this to the January 2025 milestone Jan 14, 2025
@gewarren gewarren requested a review from lonitra January 14, 2025 23:25
lonitra
lonitra approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gewarren gewarren merged commit 042ad29 into dotnet:main Jan 17, 2025
8 checks passed
@gewarren gewarren deleted the syslib0059 branch January 17, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CamSoper CamSoper Awaiting requested review from CamSoper

1 more reviewer

@lonitra lonitra lonitra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🏁 Release: .NET 10 Work items for the .NET 10 release dotnet-fundamentals/svc

Projects

None yet

Milestone

January 2025

Development

Successfully merging this pull request may close these issues.

[Breaking change]: SystemEvents.EventsThreadShutdown Obsolete with SYSLIB0059

2 participants

@gewarren @lonitra