Use 'unsafe' modifier explicitly to have it visible in code snippets #44573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #42312
It removes the
unsafescope applied to the whole class code, but applies theunsafemodifier for each separate statement that requires it, so that every time theunsafeis needed, it is clearly visible included in the code snippet presented on the page.Note: For the part with
InvokeViaFunctionPointer, where I putproductoutside of theunsafescope, is because theConsole.WriteLinethat requires thatproductto be in the same scope of course. But, thatConsole.WriteLineis not included on the page, so I'm not sure if this will not be confusing for the reader to have thatproductbeing put out ofunsafebecause... no reason from the reader perspective.(Other option, that I considered was to remove the
Console.WriteLinecall)Let me know, please, what is your opinion, when reviewing 🙏