Skip to content

Conversation

@shethaadit
Copy link
Contributor

@shethaadit shethaadit commented Feb 7, 2025

Summary

This update clarifies which My services are supported in .NET 5 and later. A new section, "Supported My Services in .NET 5+", has been added to explicitly list the supported and unsupported My objects. References to relevant APIs and documentation have been included for better discoverability.

Changes:

  • Added a new section detailing My services support in .NET 5+
  • Listed supported and unsupported My objects
  • Maintained existing structure while improving clarity
  • Ensured proper <xref:...> references and documentation links

This update improves transparency for developers migrating to .NET 5+.

Fixes #40061


Internal previews

📄 File 🔗 Preview link
docs/visual-basic/developing-apps/development-with-my/index.md Development with My (Visual Basic)

@dotnetrepoman dotnetrepoman bot added this to the February 2025 milestone Feb 7, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-visualbasic/svc community-contribution Indicates PR is created by someone from the .NET community. labels Feb 7, 2025
@BillWagner
Copy link
Member

Hi @shethaadit

There will be a delay on review for this PR. I want to check with @KlausLoeffelmann (one of our VB experts) to discuss the wording. He's currently out of the office.

Copy link
Member

@KlausLoeffelmann KlausLoeffelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The facts stated here are not correct.
Let's address those and go from there?

Thanks!

@shethaadit
Copy link
Contributor Author

The facts stated here are not correct. Let's address those and go from there?

Thanks!

Hi @KlausLoeffelmann, thank you for your comments. I have updated the wordings according to comments. Could you please review again?

@KlausLoeffelmann
Copy link
Member

I'd like to ping @paul1956 on this, if he wants to take a look?
I know there were other changes in contrast to Framework, like, I do not know, if all the device, sound, network support via My is implemented.

@paul1956 - do you happen to know by heart, what we have and what not?

@merriemcgaw: (OT) This could be another example to "crawl" an exact result, btw.

@paul1956
Copy link
Contributor

I'd like to ping @paul1956 on this, if he wants to take a look? I know there were other changes in contrast to Framework, like, I do not know, if all the device, sound, network support via My is implemented.

@paul1956 - do you happen to know by heart, what we have and what not?

@merriemcgaw: (OT) This could be another example to "crawl" an exact result, btw.

@KlausLoeffelmann Everything that I have encountered in existing VB Application that use My is working in .Net 8. Nothing is missing NOW, to my knowledge there are some behavior differences see below. I have removed all my workarounds from .Net 5. I wrote a lot of tests last year to test much of the My code, not to beat a dead horse but the only area without any tests is UploadFile and DownloadFile. All my tests were run on Framework at some point to verify identical behavior.

UploadFile and DownloadFile with ProgressDialog works differently from Framework, In Framework cancelling a transfer using ProgressDialog will immediately terminate the file transfer. In .Net through .Net 9 the transfer will complete and then be cancelled, for download the file will be deleted at the end, for upload it will depend on the server.

If I misunderstood the question, please let me know.

@KlausLoeffelmann
Copy link
Member

I'd like to ping @paul1956 on this, if he wants to take a look? I know there were other changes in contrast to Framework, like, I do not know, if all the device, sound, network support via My is implemented.
@paul1956 - do you happen to know by heart, what we have and what not?
If I misunderstood the question, please let me know.

No, perfect answer - thanks so much!
OK, so, given that we at one point HOPEFULLY will have the time to modernize the Up- and Downloading (and I acknowledge Paul's hard work here), I think we're good to go with this.

I'll ping @BillWagner. :-)

Thanks everyone!

Copy link
Member

@KlausLoeffelmann KlausLoeffelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go now!
Thanks every one!

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM as well. I'll :shipit:

@BillWagner BillWagner merged commit 015605b into dotnet:main Feb 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-visualbasic/svc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

This section should be updated to state which My services are supported in .NET 5+

4 participants