Skip to content

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented May 28, 2025

@gewarren gewarren requested a review from a team as a code owner May 28, 2025 18:17
@dotnetrepoman dotnetrepoman bot added this to the May 2025 milestone May 28, 2025
@gewarren gewarren requested review from Copilot and removed request for a team May 28, 2025 18:17
@gewarren gewarren requested a review from a team May 28, 2025 18:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the System.AccessViolationException doc to note that the HandleProcessCorruptedStateExceptions attribute is obsolete and refines guidance and wording throughout.

  • Bumped the document’s ms.date to 05/28/2025
  • Revised phrasing in the introduction and troubleshooting bullets
  • Added a “.NET Framework only” section with a caution about the attribute’s obsolescence
Comments suppressed due to low confidence (1)

docs/fundamentals/runtime-libraries/system-accessviolationexception.md:23

  • The troubleshooting bullet about verifying that memory has been allocated was removed; consider restoring it to ensure users check both allocation and corruption issues.
- Make sure that the memory that you're attempting to access has been allocated. An <xref:System.AccessViolationException> exception is always thrown by an attempt to access protected memory&mdash;that is, to access memory that's not allocated or that's not owned by a process.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren enabled auto-merge (squash) May 28, 2025 20:58
@gewarren gewarren merged commit 2d452cf into dotnet:main May 28, 2025
8 checks passed
@gewarren gewarren deleted the 45849 branch May 28, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HandleProcessCorruptedStateExceptionsAttribute is suggested for troubleshooting

2 participants