-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Improve in parameter modifier example with meaningful struct-based demonstration
#47134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot stopped work on behalf of
BillWagner due to an error
July 8, 2025 14:25
Member
|
@copilot Please start working on this again. |
Copilot stopped work on behalf of
BillWagner due to an error
July 9, 2025 13:17
Member
|
@copilot Can you start working on this again? |
Copilot stopped work on behalf of
BillWagner due to an error
July 10, 2025 12:26
Member
|
@copilot Can you start working on this again? |
…ed demonstration Co-authored-by: BillWagner <[email protected]>
Copilot
AI
changed the title
[WIP] Example seems incorrect.
Improve Jul 10, 2025
in parameter modifier example with meaningful struct-based demonstration
Copilot finished work on behalf of
BillWagner
July 10, 2025 20:42
BillWagner
approved these changes
Jul 14, 2025
Member
BillWagner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready. I'll mark it ready for final review.
Member
|
The snippets failure is related to a preview feature. |
IEvangelist
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dotnet-csharp/svc
lang-reference/subsvc
okr-quality
Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25422
Problem
The current example for the
inparameter modifier uses a simpleintparameter, which doesn't effectively demonstrate the purpose and benefits of theinmodifier. As pointed out in the issue:inkeyword, the value would still be 44 (sinceintis a value type)inin the first placeSolution
Replaced the inadequate
intexample with a comprehensive struct-based demonstration that addresses all concerns:Before (Problematic):
After (Improved):
What the New Example Demonstrates
in: Performance benefits when passing large structs (avoids copying)inparameter and regular parameter methods side-by-sideinparameters cannot be modifiedChanges Made
FirstInExample()method inRefParameterModifier.cswith meaningful struct-based exampleLargeStructdefinition with multiple fields to demonstrate performance benefitsinmodifierThe example now clearly shows why developers would choose to use the
inmodifier and provides a practical, educational demonstration of its benefits.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.