-
Notifications
You must be signed in to change notification settings - Fork 6k
Define "defining declaration" and enhance CS0759 compiler error documentation #47628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: BillWagner <[email protected]>
Copilot finished work on behalf of
BillWagner
July 29, 2025 21:21
BillWagner
reviewed
Jul 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change and this is ready.
...nguage-reference/compiler-messages/snippets/partial-declarations/partial-declarations.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: BillWagner <[email protected]>
Copilot finished work on behalf of
BillWagner
July 30, 2025 18:17
BillWagner
approved these changes
Jul 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. It's ready for final review.
gewarren
approved these changes
Aug 5, 2025
docs/csharp/language-reference/compiler-messages/partial-declarations.md
Outdated
Show resolved
Hide resolved
.../csharp/language-reference/compiler-messages/snippets/partial-declarations/CS0759Examples.cs
Outdated
Show resolved
Hide resolved
…ment punctuation Co-authored-by: gewarren <[email protected]>
Copilot finished work on behalf of
gewarren
August 5, 2025 20:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
csharp-diagnostics/subsvc
dotnet-csharp/svc
lang-reference/subsvc
okr-quality
Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CS0759 compiler error documentation was unclear about what a "defining declaration" means, leaving users confused when encountering this error. The existing documentation simply stated "No defining declaration found..." without explaining the concept or providing working examples.
Changes Made
Enhanced Documentation: Added comprehensive explanation for CS0759 that:
Code Examples: Created practical examples showing:
Incorrect code that generates CS0759:
Correct fix - separate partial declarations:
Alternative fix - both in same partial class:
The enhanced documentation now clearly explains what a "defining declaration" is, why the CS0759 error occurs, and provides practical examples of both the error scenario and its resolution.
Fixes #27997.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.
Internal previews