Add warning about accessing managed resources in finalizers #47706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: BillWagner <[email protected]>
Copilot
AI
changed the title
[WIP] Cleanup of managed resources in the finalizer?
Add warning about accessing managed resources in finalizers
Aug 1, 2025
Copilot finished work on behalf of
BillWagner
August 1, 2025 19:36
BillWagner
reviewed
Aug 4, 2025
docs/csharp/programming-guide/classes-and-structs/finalizers.md
Outdated
Show resolved
Hide resolved
dotnet-policy-service
bot
added
the
okr-quality
Co-authored-by: BillWagner <[email protected]>
BillWagner
approved these changes
Aug 4, 2025
BillWagner
approved these changes
Aug 4, 2025
gewarren
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The finalizers documentation was missing important guidance about the safety of accessing managed object members from finalizers. This could lead developers to write unsafe code that attempts to access managed objects that may have already been disposed.
This change adds a warning in the "Using finalizers to release resources" section that clearly advises developers against accessing managed object members from finalizers. The warning explains that managed objects might already be disposed during finalization, making them unavailable or in an invalid state, and emphasizes that finalizers should only access unmanaged resources directly.
The warning follows Microsoft documentation standards using the
[!WARNING]callout format and is positioned appropriately in the section that discusses what finalizers should be used for.Fixes #31199.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Internal previews