-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Replace shared include file with platform-specific checksum validation instructions #47869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: adegeo <[email protected]>
|
@copilot Instead of the changes you made, can you actually port this into the individual articles that reference the include file, then remove the include file? Adjust the include file's content to be specific to platform covered by the article. So the |
I'll implement this cleaner approach by removing the include file and porting platform-specific content directly into each article. This will eliminate the need for a shared include that tries to handle both platforms. |
Co-authored-by: adegeo <[email protected]>
|
The build warning is unrelated. Closing and reopening for a fresh build |
BillWagner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot you need to fix the broken links to the images.
Co-authored-by: BillWagner <[email protected]>
BillWagner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now LGTM.
The current .NET installation documentation uses a shared include file
verify-download-macos-linux.mdthat attempts to handle both Linux and macOS checksum validation in a single file. This approach creates unnecessary complexity and makes the documentation harder to maintain.This PR replaces the shared include approach with platform-specific content directly in each article:
Changes made:
docs/core/install/includes/verify-download-macos-linux.mddocs/core/install/linux-scripted-manual.mdwith Linux-specific instructions usingsha512sumcommandsdocs/core/install/macos.mdwith macOS-specific instructions usingshasum -a 512commandslinux-x64vsosx-x64)Benefits:
Platform-specific commands:
sha512sumandsha512sum -c {file} --ignore-missingshasum -a 512andshasum -a 512 -c {file}Both commands produce identical SHA512 checksums for validation, but use the native tools available on each platform.
Fixes #47112.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Internal previews