-
Notifications
You must be signed in to change notification settings - Fork 6k
[Diagnostics][dotnet-trace] Add collect-linux verb #47894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Diagnostics][dotnet-trace] Add collect-linux verb #47894
Conversation
bc293c0
to
e1a3ec7
Compare
- **perf**: Use `perf list user_events*` to see available events | ||
- **System monitoring tools**: Any tool that can consume Linux tracepoints | ||
|
||
### Examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lower in this doc are some examples of using dotnet-trace collect in various situations. No need just yet, but we'd probably want to update or add to those examples for the collect-linux functionality once we've clarified what it will be.
This reverts commit e1a3ec7.
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
728afed
to
26adb7b
Compare
When `--profiles`, `--clrevents`, and `--providers` aren’t specified, `collect-linux` enables the default `profile` providing the comprehensive composition: | ||
|
||
- `dotnet-common` — lightweight .NET runtime diagnostics. | ||
- `dotnet-thread-time` — runtime thread stack sampling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These events aren't useful under user_events because we aren't including managed stack traces in the event data we report to the kernel. We shouldn't include this in the default. We might even want to include a warning if someone tried to turn this on explicitly with the --profile option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed from the collect-linux
set of profiles. I think we will need some specifier for dotnet-trace list-profiles
to delimit which profiles are valid for collect
vs collect-linux
.
Summary
Add new
collect-linux
verb to utilize new user_events based event tracing.Internal previews