-
Notifications
You must be signed in to change notification settings - Fork 6k
Replace dotnet.config with global.json in dotnet test #48295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mariam-abdulla
wants to merge
8
commits into
dotnet:main
Choose a base branch
from
mariam-abdulla:replace-dotnet.config-with-global.json
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e1353c7
replace dotnet.config with global.json
mariam-abdulla 41fcf51
Remove occurences of dotnet.config
mariam-abdulla 7e9cef6
Add link of global.json
mariam-abdulla f1463a3
Update docs/core/testing/unit-testing-with-dotnet-test.md
mariam-abdulla 47d0415
Update global.json doc
mariam-abdulla 3e4a371
Merge branch 'replace-dotnet.config-with-global.json' of https://gith…
mariam-abdulla 13046a9
Update docs/core/tools/global-json.md
mariam-abdulla 7ab5866
Update docs/core/tools/global-json.md
mariam-abdulla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other PR is merged.
One small question. Should we actually briefly mention that during early previews and RC1 this was using dotnet.config, which we dropped in favor of global.json in RC2?
I want to avoid confusion when people are trying to use RC1 (because RC2 isn't released yet).
@gewarren Is there generally some policy docs follow when there is a breaking change between RC1 and RC2 when RC2 isn't yet released?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We often publish preview to preview breaking changes and then just delete the breaking change article at GA. But if this change is in RC 2, I think we should wait to publish this until RC 2 ships.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. We can wait until RC2 ships then.