Skip to content

Replace problematic DoEvents example with console-based RaiseEvent demonstration #48538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 17, 2025
Merged

Replace problematic DoEvents example with console-based RaiseEvent demonstration #48538

merged 6 commits into from
Sep 17, 2025
+34 −51

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Sep 15, 2025 •
edited by github-actions bot
Loading

  • Replace problematic DoEvents example with console-based RaiseEvent demonstration
  • Fix VB.NET syntax errors in code snippets:
    • Fix string interpolation syntax (use VB.NET format instead of C#)
    • Fix duplicate mTimer declarations
    • Fix Console.WriteLine usage in Windows Forms context by moving to standalone classes
    • Ensure code compiles properly with modern VB.NET syntax
  • Validate that examples work correctly and demonstrate RaiseEvent properly
  • Address review feedback:
    • Remove "simple" qualifier from timer description
    • Add link to RaiseEvent language reference

Fixes #34917

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Internal previews

📄 File 🔗 Preview link
docs/visual-basic/language-reference/statements/raiseevent-statement.md RaiseEvent Statement

@dotnet-policy-service dotnet-policy-service bot added the okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. label Sep 15, 2025
@Copilot Copilot AI changed the title [WIP] Suggestion to use My.Application.DoEvents is irresponsible. Replace problematic DoEvents example with console-based RaiseEvent demonstration Sep 15, 2025
@Copilot Copilot AI requested a review from BillWagner September 15, 2025 20:51
Copilot finished work on behalf of BillWagner September 15, 2025 20:51
@BillWagner
Copy link
Member

@copilot Fix the build errors in the code sample

@Copilot @BillWagner
Fix VB.NET syntax errors in RaiseEvent example - remove C# string int…
7ed9193 
…erpolation, move to standalone classes, use proper VB syntax

Co-authored-by: BillWagner <[email protected]>
@Copilot Copilot SWE Agent
Copy link
Contributor Author

Copilot AI commented Sep 16, 2025

@copilot Fix the build errors in the code sample

Fixed the build errors in the VB code samples. The issues were:

  1. Using C# string interpolation syntax ($"...") instead of VB.NET string concatenation
  2. Mixing Console.WriteLine with Windows Forms context
  3. Improper class nesting structure

The code now uses proper VB.NET syntax with standalone classes and compiles cleanly. Commit: 7ed9193

BillWagner
BillWagner reviewed Sep 16, 2025
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more changes and this is ready.

@BillWagner
Copy link
Member

@copilot Please address the remaining review comment.

@Copilot Copilot SWE Agent
Copy link
Contributor Author

Copilot AI commented Sep 16, 2025

@copilot Please address the remaining review comment.

Addressed the review feedback:

  1. Removed "simple" qualifier from timer description
  2. Added link to RaiseEvent language reference in the example description

Commit: 1e673a5

@Copilot Copilot AI requested a review from BillWagner September 16, 2025 14:11
BillWagner
BillWagner approved these changes Sep 16, 2025
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready for final review.

@BillWagner BillWagner marked this pull request as ready for review September 16, 2025 14:13
@BillWagner BillWagner requested a review from a team as a code owner September 16, 2025 14:13
@BillWagner BillWagner requested a review from gewarren September 16, 2025 14:13
@BillWagner BillWagner merged commit 9a6e16d into main Sep 17, 2025
10 checks passed
@BillWagner BillWagner deleted the copilot/fix-34917 branch September 17, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

+1 more reviewer

@BillWagner BillWagner BillWagner approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@BillWagner BillWagner

Copilot code review Copilot

Labels
dotnet-visualbasic/svc okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion to use My.Application.DoEvents is irresponsible.
3 participants
@Copilot @BillWagner @gewarren