Fix conflicting System.Exception recommendation in Visual Basic documentation #48548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Visual Basic documentation for the
Throw
statement was showing an example that conflicts with established .NET best practices. The example demonstrated throwingSystem.Exception
directly:However, the C# documentation correctly advises against this practice, stating: "Don't throw
System.Exception
,System.SystemException
,System.NullReferenceException
, orSystem.IndexOutOfRangeException
intentionally from your own source code."This created inconsistent guidance across the .NET documentation where Visual Basic developers might follow the example and violate best practices.
The fix updates the Visual Basic example to use
InvalidOperationException
instead:This change:
InvalidOperationException
, which is explicitly recommended in the best practices documentationThrow
statement syntaxFixes #35262.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.