-
Notifications
You must be signed in to change notification settings - Fork 6k
Add example section to CA2017 documentation with C# and VB code snippets #48743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gewarren
merged 5 commits into
main
from
copilot/fix-53d6069d-978c-4a75-a4b0-1e0de1212989
Sep 25, 2025
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
20fef81
Initial plan
Copilot 9f371b3
Add example section to CA2017 documentation with C# and VB snippets
Copilot 73ddd9d
Add AI usage disclosure to CA2017 documentation frontmatter
Copilot b07d928
human edits
gewarren 4c43c2b
Update docs/fundamentals/code-analysis/quality-rules/snippets/csharp/…
gewarren File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
docs/fundamentals/code-analysis/quality-rules/snippets/csharp/all-rules/ca2017.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
using Microsoft.Extensions.Logging; | ||
|
||
namespace ca2017 | ||
{ | ||
// <snippet1> | ||
public class LoggingExample | ||
{ | ||
private readonly ILogger<LoggingExample> _logger; | ||
|
||
public LoggingExample(ILogger<LoggingExample> logger) | ||
{ | ||
_logger = logger; | ||
} | ||
|
||
public void ExampleMethod() | ||
{ | ||
string name = "Alice"; | ||
int age = 30; | ||
|
||
// Violates CA2017: Too few arguments for placeholders. | ||
_logger.LogInformation("User {Name} is {Age} years old and lives in {City}", name, age); | ||
|
||
// Violates CA2017: Too many arguments for placeholders. | ||
_logger.LogError("Error occurred: {Message}", "Something went wrong", "Extra argument"); | ||
|
||
// Correct usage: Matching number of placeholders and arguments. | ||
_logger.LogInformation("User {Name} is {Age} years old", name, age); | ||
} | ||
} | ||
// </snippet1> | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
...ls/code-analysis/quality-rules/snippets/vb/all-rules/ca2017-parameter-count-mismatch_1.vb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
Imports Microsoft.Extensions.Logging | ||
|
||
Public Class LoggingExample | ||
|
||
Private ReadOnly _logger As ILogger(Of LoggingExample) | ||
|
||
Public Sub New(logger As ILogger(Of LoggingExample)) | ||
_logger = logger | ||
End Sub | ||
|
||
Public Sub ExampleMethod() | ||
Dim name As String = "Alice" | ||
Dim age As Integer = 30 | ||
|
||
' Violates CA2017: Too few arguments for placeholders. | ||
_logger.LogInformation("User {Name} is {Age} years old and lives in {City}", name, age) | ||
|
||
' Violates CA2017: Too many arguments for placeholders. | ||
_logger.LogError("Error occurred: {Message}", "Something went wrong", "Extra argument") | ||
|
||
' Correct usage: Matching number of placeholders and arguments. | ||
_logger.LogInformation("User {Name} is {Age} years old", name, age) | ||
End Sub | ||
|
||
End Class |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.