Modernize code examples for CA rules #48745
Merged
+169
−282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
approved these changes
Oct 1, 2025
docs/fundamentals/code-analysis/quality-rules/snippets/csharp/all-rules/ca1045.cs
Outdated
Show resolved
Hide resolved
docs/fundamentals/code-analysis/quality-rules/snippets/csharp/all-rules/ca1806.cs
Outdated
Show resolved
Hide resolved
docs/fundamentals/code-analysis/quality-rules/snippets/csharp/all-rules/ca1806.cs
Show resolved
Hide resolved
docs/fundamentals/code-analysis/quality-rules/snippets/csharp/all-rules/ca2227.cs
Outdated
Show resolved
Hide resolved
docs/fundamentals/code-analysis/quality-rules/snippets/csharp/all-rules/ca2235.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes code examples for CA (Code Analysis) rules by updating them to use contemporary C# and VB.NET syntax and patterns. The changes improve readability and demonstrate current best practices while maintaining the same educational purpose.
- Replaces older syntax with modern equivalents (collection expressions, target-typed new expressions, primary constructors)
- Updates data access examples from SQL Server to OLE DB with appropriate platform attributes
- Removes unnecessary code and simplifies class implementations using modern language features
Reviewed Changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| CA2235 snippet files | Modernized serialization example with primary constructor and auto-properties |
| CA2100 snippet files | Updated SQL examples to use OLE DB with platform-specific attributes |
| CA1816 snippet files | Replaced SQL connection examples with MemoryStream for simpler disposal pattern |
| CA1806 snippet files | Modernized method result handling examples with null-conditional operators |
| CA1045 snippet files | Extensively modernized ref/out parameter examples with records and switch expressions |
| Various CA rule snippets | Applied target-typed new expressions, collection expressions, and simplified syntax |
| Documentation files | Updated example structure and minor text improvements |
| .editorconfig files | Added CA2100 severity configuration |
...lity-rules/snippets/vb/all-rules/ca2100-review-sql-queries-for-security-vulnerabilities_1.vb
Outdated
Show resolved
Hide resolved
docs/fundamentals/code-analysis/quality-rules/snippets/csharp/all-rules/ca1045.cs
Show resolved
Hide resolved
docs/fundamentals/code-analysis/quality-rules/snippets/csharp/all-rules/ca1045.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #48007.
Requires #48743 to be merged first (for project files).Internal previews