Add new compiler errors for #: and consolidate all existing preprocessor errors
#48947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate existing errors and warnings related to preprocessor directives into this one file.
I had copilot search for additional files that I had missed earlier in the appropriate folders. These are the ones it found.
In step 3, use the source from roslyn to find any additional errors and warnings that haven't been covered.
Create combined sections for related errors and warnings. Provide links to relevant language-reference articles.
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates all preprocessor-related compiler errors and warnings into a single new document to improve organization and discoverability. It addresses issue #46451 by creating a centralized location for all preprocessor error documentation.
- Creates a new comprehensive
preprocessor-errors.mdfile that consolidates all preprocessor-related error documentation - Removes individual error files from the
miscfolder that are now covered by the new consolidated file - Updates navigation and redirection configuration to point to the new consolidated documentation
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.github/prompts/error-consolidation.md |
Adds guidance prompts for consolidating error codes |
.openpublishing.redirection.csharp.json |
Adds redirects from individual error pages to the new consolidated file |
docs/csharp/language-reference/compiler-messages/cs1029.md |
Removes individual error file (now consolidated) |
docs/csharp/language-reference/compiler-messages/cs1691.md |
Removes individual error file (now consolidated) |
docs/csharp/language-reference/compiler-messages/nullable-warnings.md |
Adds CS8668 to nullable warnings documentation |
docs/csharp/language-reference/compiler-messages/preprocessor-errors.md |
Creates new consolidated preprocessor errors documentation |
docs/csharp/language-reference/preprocessor-directives.md |
Updates links to point to new consolidated error documentation |
docs/csharp/language-reference/toc.yml |
Adds navigation entry for the new preprocessor errors page |
docs/csharp/misc/cs*.md (multiple files) |
Removes individual error files that are now consolidated |
docs/csharp/misc/sorry-we-don-t-have-specifics-on-this-csharp-error.md |
Updates error code lists to reflect consolidation |
docs/csharp/language-reference/compiler-messages/preprocessor-errors.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/compiler-messages/preprocessor-errors.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
IEvangelist
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46451
I made extensive use of Copilot for this PR. I used agent mode in VS Code. The new file in prompts is the first pass at creating the file. It can probably be improved for the set of prompts. On the next PR for errors and warnings, I'll iterate and improve the prompts.
Internal previews