Add additional extension errors #49290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#46453 After new operators were added, new diagnostics were necessary in the area of extensions. Also, pick up a few other stragglers added for other features.
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation for additional C# compiler errors related to extension declarations, addressing issue #46453. The changes update error lists and documentation to include new diagnostics that were introduced with recent operators and other language features.
Key changes:
- Added 12 new extension-related error codes (CS9306, CS9309, CS9316-CS9323, CS9326, CS9329) to various documentation files
- Added 2 new pattern matching warning codes (CS9335, CS9337) with examples and explanations
- Updated table of contents entries to include the new error codes
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sorry-we-don-t-have-specifics-on-this-csharp-error.md | Removed redundant error codes and added CS9338 to the list |
| toc.yml | Added new extension and pattern matching error codes to appropriate sections |
| Switch.cs | Added code example demonstrating redundant pattern matching scenarios |
| pattern-matching-warnings.md | Added documentation for CS9335 and CS9337 with examples and explanations |
| extension-declarations.md | Added comprehensive documentation for 12 new extension-related error codes |
docs/csharp/language-reference/compiler-messages/pattern-matching-warnings.md
Show resolved
Hide resolved
docs/csharp/language-reference/compiler-messages/extension-declarations.md
Show resolved
Hide resolved
BillWagner
commented
Oct 16, 2025
meaghanlewis
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46453
After new operators were added, new diagnostics were necessary in the area of extensions.
Also, pick up a few other stragglers added for other features.
Internal previews
thisparameters orextensionblocks