Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/instructions/Markdown.WritingStyle.instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ ALWAYS:
- **MANDATORY: Number ordered lists using "1." for every item (NOT 1., 2., 3.) - ALWAYS USE "1."**
- **REQUIRED: Use bullets for unordered lists - NEVER use numbers for unordered content**
- **ESSENTIAL: Write complete sentences in lists with proper punctuation**
- **MUST: End list items with periods if more than three words - THIS IS NON-NEGOTIABLE**
- **MUST: End list items with periods if more than three words. The period may be inside style marks like `*` for italic or `**` for bold - THIS IS NON-NEGOTIABLE**
- Skip end punctuation on titles, headings, and UI elements (3 words or fewer)

### Spacing and Layout
Expand Down
17 changes: 14 additions & 3 deletions .github/prompts/error-consolidation.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ Overall steps:

We're going to work through a series of files consolidating errors and warnings.

- For the duration of this chat, all references to "destination file" refer to `attribute-usage-errors.md`.
- For the duration of this chat, all references to "the target theme" refer to errors and warnings related to declaring and using *attributes*.
- For the duration of this chat, all references to "destination file" refer to `generic-type-parameters-errors.md`.
- For the duration of this chat, all references to "the target theme" refer to errors and warnings related to generic type parameters and generic type arguments.

The destination file already contains a skeleton for the final output.

Expand Down Expand Up @@ -64,5 +64,16 @@ Understand these instructions, then suggest a list of themes and the included er

## Move from description to resolution

Rework the highlighted section so the focus is on how to correct each error. This article doesn't need to explain the associated language feature. Instead, in each section, provide links to language reference or language specification material that explains the rules violated when these diagnostics appear. Add explanatory context after each correction (in parentheses with the error code). Provided brief reasons why each correction is needed. Use detailed, sentence-style explanations rather than brief imperative statements. For each recommendation put the affectived error codes in parentheses, and in **bold** style. Remove extensive examples.
Rework the highlighted section so the focus is on how to correct each error. This article doesn't need to explain the associated language feature. Instead, in each section, provide links to language reference or language specification material that explains the rules violated when these diagnostics appear. Add explanatory context after each correction (in parentheses with the error code). Provided brief reasons why each correction is needed. Use detailed, sentence-style explanations rather than brief imperative statements. For each recommendation put the affectived error codes in parentheses, and in **bold** style. Remove extensive examples. Remove all H3 headings in this section. If any errors are no longer produced in the latest version of C#, make a note of that.

## Verify error messages

For every line in this table, verify that the error message associated with this error code matches the verbatim text in CSharpResources.resx. You can find the mapping using ErrorCodes.cs:

1. Find that number as a constant in `ErrorCodes.cs`.
2. Locate the corresponding `data` element in CSharpResources.resx. The `name` atttribute should match the number of the constant.
3. Read the error message found in the `<value>` element that is a child of that `<data>` element.

<make your own hand edits>

Now, ensure every instance of an error message matches the text in the highlighted table.
176 changes: 176 additions & 0 deletions .openpublishing.redirection.csharp.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,105 @@
{
"redirections": [
{
"source_path_from_root": "/docs/csharp/misc/cs0080.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/docs/csharp/misc/cs0081.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/docs/csharp/misc/cs0305.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/docs/csharp/misc/cs0306.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/docs/csharp/misc/cs0307.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/docs/csharp/misc/cs0308.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/docs/csharp/misc/cs0312.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/docs/csharp/misc/cs0313.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/docs/csharp/misc/cs0314.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/docs/csharp/misc/cs0315.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/docs/csharp/misc/cs0403.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/docs/csharp/misc/cs0412.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/docs/csharp/misc/cs0694.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/docs/csharp/misc/cs0695.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/docs/csharp/misc/cs0698.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/docs/csharp/language-reference/compiler-messages/cs0304.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/docs/csharp/language-reference/compiler-messages/cs0310.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/docs/csharp/language-reference/compiler-messages/cs0311.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/docs/csharp/language-reference/compiler-messages/cs0413.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/docs/csharp/language-reference/compiler-messages/cs0417.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/generic-type-parameters-errors",
"redirect_document_id": false
},
{
"source_path_from_root": "/redirections/proposals/csharp-7.0/binary-literals.md",
"redirect_url": "/dotnet/csharp/language-reference/language-specification/lexical-structure#6453-integer-literals"
Expand Down Expand Up @@ -315,6 +415,18 @@
"source_path_from_root": "/docs/csharp/language-reference/compiler-messages/cs0034.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/overload-resolution"
},
{
"source_path_from_root": "/docs/csharp/language-reference/compiler-messages/cs0071.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/language-reference/compiler-messages/cs0106.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0277.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/language-reference/compiler-messages/cs0178.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/array-declaration-errors"
Expand Down Expand Up @@ -355,6 +467,22 @@
"source_path_from_root": "/docs/csharp/language-reference/compiler-messages/cs0650.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/array-declaration-errors"
},
{
"source_path_from_root": "/docs/csharp/language-reference/compiler-messages/cs0686.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0736.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0737.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0738.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/language-reference/compiler-messages/cs0767.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/ref-modifiers-errors"
Expand Down Expand Up @@ -1833,10 +1961,34 @@
"source_path_from_root": "/docs/csharp/misc/cs0457.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/overload-resolution"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0425.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0460.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0466.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/params-arrays"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0470.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0473.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0531.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0535.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0501.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/partial-declarations"
Expand Down Expand Up @@ -1865,6 +2017,30 @@
"source_path_from_root": "/docs/csharp/misc/cs0526.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/constructor-errors#constructor-declarations"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0538.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0539.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0540.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0541.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0550.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0551.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0553.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/overloaded-operator-errors"
Expand Down
Loading
Loading