-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Document JapaneseCalendar.MinSupportedDateTime breaking change in .NET 11 Preview 1 #50920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…correction - Create japanese-calendar-min-date.md breaking change article for .NET 11 Preview 1 - Create 11.0.md index file for .NET 11 breaking changes - Update toc.yml to include .NET 11 section with Globalization subsection - Document change from 1868-09-08 to 1868-10-23 as minimum supported date - Reference CLDR-11375 and WorkItem 543457
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR documents a breaking change in .NET 11 Preview 1 where the Japanese Calendar's minimum supported date was corrected from 1868-09-08 to 1868-10-23 to align with Unicode CLDR data. The change updates the JapaneseCalendar.MinSupportedDateTime property value and invalidates dates in the 45-day gap between the old and new dates.
Key changes:
- Creates new breaking change documentation for the Japanese Calendar date correction
- Adds .NET 11 Globalization section to the breaking changes index
- Updates the table of contents to include the new breaking change entry
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/core/compatibility/globalization/11/japanese-calendar-min-date.md | New breaking change documentation describing the Japanese Calendar minimum date correction, including previous/new behavior, reason for change, and affected APIs |
| docs/core/compatibility/11.md | Adds Globalization section to the .NET 11 breaking changes index with entry for Japanese Calendar change |
| docs/core/compatibility/toc.yml | Updates table of contents to include Globalization subsection under .NET 11 with link to new Japanese Calendar article |
| docs/core/compatibility/core-libraries/11/environment-tickcount-windows-behavior.md | Corrects title punctuation from hyphen to colon for consistency with other breaking change documents |
BillWagner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Let's ![]()
The Japanese Calendar minimum supported date changed from
1868-09-08to1868-10-23in .NET 11 Preview 1 to align with Unicode CLDR data (CLDR-11375). This affectsJapaneseCalendar.MinSupportedDateTimeand invalidates dates in the 45-day gap.Changes
Created
docs/core/compatibility/globalization/11.0/japanese-calendar-min-date.mdJapaneseCalendar.MinSupportedDateTime1868-09-08and1868-10-23Created
docs/core/compatibility/11.0.mdUpdated
docs/core/compatibility/toc.ymlExample Impact
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Internal previews