Update title to BinaryReader.ReadString #50988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
dotnet-fundamentals/svc
community-contribution
gewarren
reviewed
Jan 9, 2026
Contributor
gewarren
left a comment
gewarren
left a comment
There was a problem hiding this comment.
Thanks @Ramo-Y. Can you please also update the tile in the TOC and index page?
Co-authored-by: Genevieve Warren <[email protected]>
Contributor
Author
|
@dotnet-policy-service agree |
gewarren
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The title of the breaking change for
BinaryReader.ReadStringwasBinaryReader.GetString, even though the code referred toSystem.IO.BinaryReader.ReadStringInternal previews