Open
Conversation
ivanPeshterskii
requested review from
a team,
BillWagner and
adegeo
as code owners
dotnet-policy-service
bot
added
dotnet-fundamentals/svc
dotnet-docker/subsvc
community-contribution
BillWagner
reviewed
Apr 10, 2026
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
Thanks @ivanPeshterskii
I had a couple comments to consider before we merge this.
Comment on lines
12
to
14
Member
There was a problem hiding this comment.
Please revert this change. It doesn't follow our coding guidelines. We prefer only using this. when necessary to disambiguate.
Comment on lines
17
to
37
Member
There was a problem hiding this comment.
If we're making updates, I'd change these to field backed auto-properties.
Refactor properties to use expression-bodied members and remove 'this' references for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add some comments, public properties and encapsulation in order to follow SOLID principles