Port WinForms docs for 9.0 #10247

lonitra · 2024-08-13T17:44:33Z

Summary

Fixes dotnet/winforms#11845
Followed porting instructions in main issue

porting documentation for darkmode / async feature still pending

learn-build-service-prod · 2024-08-13T18:12:19Z

Learn Build status updates of commit 5c3c75e:

✅ Validation status: passed

File	Status	Preview URL
xml/System.Windows.Forms.Design.Behavior/BehaviorServiceAdornerCollection.xml	✅Succeeded	View
xml/System.Windows.Forms/AccessibleEvents.xml	✅Succeeded	View
xml/System.Windows.Forms/Application.xml	✅Succeeded	View
xml/System.Windows.Forms/GiveFeedbackEventArgs.xml	✅Succeeded	View
xml/System.Windows.Forms/ToolStrip.xml	✅Succeeded	View
xml/System.Windows.Forms/ToolStripItem.xml	✅Succeeded	View

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

carlossanlop

Left some comments.

xml/System.Windows.Forms/ToolStripItem.xml

xml/System.Windows.Forms/ToolStrip.xml

xml/System.Windows.Forms/GiveFeedbackEventArgs.xml

learn-build-service-prod · 2024-08-19T22:51:29Z

Learn Build status updates of commit 6fccd41:

✅ Validation status: passed

File	Status	Preview URL
xml/System.Windows.Forms.Design.Behavior/BehaviorServiceAdornerCollection.xml	✅Succeeded	View
xml/System.Windows.Forms/AccessibleEvents.xml	✅Succeeded	View
xml/System.Windows.Forms/Application.xml	✅Succeeded	View
xml/System.Windows.Forms/GiveFeedbackEventArgs.xml	✅Succeeded	View
xml/System.Windows.Forms/ToolStripItem.xml	✅Succeeded	View

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

learn-build-service-prod · 2024-08-19T23:12:12Z

Learn Build status updates of commit 9665cc6:

✅ Validation status: passed

File	Status	Preview URL
xml/System.Windows.Forms.Design.Behavior/BehaviorServiceAdornerCollection.xml	✅Succeeded	View
xml/System.Windows.Forms/AccessibleEvents.xml	✅Succeeded	View
xml/System.Windows.Forms/Application.xml	✅Succeeded	View
xml/System.Windows.Forms/GiveFeedbackEventArgs.xml	✅Succeeded	View
xml/System.Windows.Forms/ToolStripItem.xml	✅Succeeded	View

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

xml/System.Windows.Forms/GiveFeedbackEventArgs.xml

xml/System.Windows.Forms/ToolStripItem.xml

lonitra · 2024-08-27T20:51:52Z

@gewarren do we have an estimate for when the CI update for RC 1 will be? WinForms has some experimental apis that were introduced in RC1 so this is in draft to get those docs ported as well.

gewarren · 2024-08-27T20:53:52Z

@gewarren do we have an estimate for when the CI update for RC 1 will be? WinForms has some apis that were introduced in RC1 so this is in draft to get those docs ported as well.

@lonitra It's usually a couple of days after it releases.

carlossanlop · 2024-09-05T19:38:37Z

@lonitra so I assume you're going to wait for RC1 to be released before merging this?

lonitra · 2024-09-05T20:00:24Z

so I assume you're going to wait for RC1 to be released before merging this?

Yes, we need the documentation for the experimental APIs as well to finish up documentation for net 9 so this will need to wait until the CI update.

Co-authored-by: Carlos Sánchez López <[email protected]>

learn-build-service-prod · 2024-09-19T20:05:31Z

Learn Build status updates of commit 751cfe7:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File	Status	Preview URL	Details
	❌Error		Details
xml/System.Windows.Forms/ToolStrip.xml	❌Error		Details

Line 0, Column 0: [Error: ECMA2Yaml_File_LoadFailed] Failed to load 1 files, aborting...

xml/System.Windows.Forms/ToolStrip.xml

Line 0, Column 0: [Error: ECMA2Yaml_InternalError]

Intenal Several Error: System.Xml.XmlException: The 'Members' start tag on line 117 position 4 does not match the end tag of 'Member'. Line 210, position 7.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String[] args)
   at System.Xml.XmlTextReaderImpl.ThrowTagMismatch(NodeData startTag)
   at System.Xml.XmlTextReaderImpl.ParseEndElement()
   at System.Xml.XmlTextReaderImpl.ParseElementContent()
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)
   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
   at System.Xml.Linq.XDocument.Parse(String text, LoadOptions options)
   at ECMA2Yaml.ECMALoader.LoadType(FileItem typeFile)
   at ECMA2Yaml.ECMALoader.LoadTypes(String basePath, Namespace ns)

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

Co-authored-by: Genevieve Warren <[email protected]>

xml/System.Windows.Forms/ToolStripItem.xml

learn-build-service-prod · 2024-09-19T20:27:45Z

Learn Build status updates of commit efccf59:

✅ Validation status: passed

File	Status	Preview URL
xml/System.Windows.Forms.Design.Behavior/BehaviorServiceAdornerCollection.xml	✅Succeeded	View
xml/System.Windows.Forms/AccessibleEvents.xml	✅Succeeded	View
xml/System.Windows.Forms/Application.xml	✅Succeeded	View
xml/System.Windows.Forms/ButtonBase.xml	✅Succeeded	View
xml/System.Windows.Forms/ButtonRenderer.xml	✅Succeeded	View
xml/System.Windows.Forms/CheckBoxRenderer.xml	✅Succeeded	View
xml/System.Windows.Forms/Control.xml	✅Succeeded	View
xml/System.Windows.Forms/ControlStyles.xml	✅Succeeded	View
xml/System.Windows.Forms/Form.xml	✅Succeeded	View
xml/System.Windows.Forms/FormCornerPreference.xml	✅Succeeded	View
xml/System.Windows.Forms/GiveFeedbackEventArgs.xml	✅Succeeded	View
xml/System.Windows.Forms/RadioButtonRenderer.xml	✅Succeeded	View
xml/System.Windows.Forms/SystemColorMode.xml	✅Succeeded	View
xml/System.Windows.Forms/TaskDialog.xml	✅Succeeded	View
xml/System.Windows.Forms/ToolStrip.xml	✅Succeeded	View
xml/System.Windows.Forms/ToolStripItem.xml	✅Succeeded	View

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

into winformsdoc

learn-build-service-prod · 2024-09-19T20:57:45Z

Learn Build status updates of commit 639c2e7:

✅ Validation status: passed

File	Status	Preview URL
xml/System.Windows.Forms.Design.Behavior/BehaviorServiceAdornerCollection.xml	✅Succeeded	View
xml/System.Windows.Forms/AccessibleEvents.xml	✅Succeeded	View
xml/System.Windows.Forms/Application.xml	✅Succeeded	View
xml/System.Windows.Forms/ButtonBase.xml	✅Succeeded	View
xml/System.Windows.Forms/ButtonRenderer.xml	✅Succeeded	View
xml/System.Windows.Forms/CheckBoxRenderer.xml	✅Succeeded	View
xml/System.Windows.Forms/Control.xml	✅Succeeded	View
xml/System.Windows.Forms/ControlStyles.xml	✅Succeeded	View
xml/System.Windows.Forms/Form.xml	✅Succeeded	View
xml/System.Windows.Forms/FormCornerPreference.xml	✅Succeeded	View
xml/System.Windows.Forms/GiveFeedbackEventArgs.xml	✅Succeeded	View
xml/System.Windows.Forms/RadioButtonRenderer.xml	✅Succeeded	View
xml/System.Windows.Forms/SystemColorMode.xml	✅Succeeded	View
xml/System.Windows.Forms/TaskDialog.xml	✅Succeeded	View
xml/System.Windows.Forms/ToolStrip.xml	✅Succeeded	View
xml/System.Windows.Forms/ToolStripItem.xml	✅Succeeded	View

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

Co-authored-by: Genevieve Warren <[email protected]>

learn-build-service-prod · 2024-09-20T16:57:46Z

Learn Build status updates of commit baeea0d:

✅ Validation status: passed

File	Status	Preview URL
xml/System.Windows.Forms.Design.Behavior/BehaviorServiceAdornerCollection.xml	✅Succeeded	View
xml/System.Windows.Forms/AccessibleEvents.xml	✅Succeeded	View
xml/System.Windows.Forms/Application.xml	✅Succeeded	View
xml/System.Windows.Forms/ButtonBase.xml	✅Succeeded	View
xml/System.Windows.Forms/ButtonRenderer.xml	✅Succeeded	View
xml/System.Windows.Forms/CheckBoxRenderer.xml	✅Succeeded	View
xml/System.Windows.Forms/Control.xml	✅Succeeded	View
xml/System.Windows.Forms/ControlStyles.xml	✅Succeeded	View
xml/System.Windows.Forms/Form.xml	✅Succeeded	View
xml/System.Windows.Forms/FormCornerPreference.xml	✅Succeeded	View
xml/System.Windows.Forms/GiveFeedbackEventArgs.xml	✅Succeeded	View
xml/System.Windows.Forms/RadioButtonRenderer.xml	✅Succeeded	View
xml/System.Windows.Forms/SystemColorMode.xml	✅Succeeded	View
xml/System.Windows.Forms/TaskDialog.xml	✅Succeeded	View
xml/System.Windows.Forms/ToolStrip.xml	✅Succeeded	View
xml/System.Windows.Forms/ToolStripItem.xml	✅Succeeded	View

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

xml/System.Windows.Forms/Application.xml

xml/System.Windows.Forms/TaskDialog.xml

xml/System.Windows.Forms/ToolStripItem.xml

xml/System.Windows.Forms/TaskDialog.xml

Co-authored-by: Carlos Sánchez López <[email protected]>

learn-build-service-prod · 2024-09-21T04:35:28Z

Learn Build status updates of commit 2e67e63:

✅ Validation status: passed

File	Status	Preview URL
xml/System.Windows.Forms.Design.Behavior/BehaviorServiceAdornerCollection.xml	✅Succeeded	View
xml/System.Windows.Forms/AccessibleEvents.xml	✅Succeeded	View
xml/System.Windows.Forms/Application.xml	✅Succeeded	View
xml/System.Windows.Forms/ButtonBase.xml	✅Succeeded	View
xml/System.Windows.Forms/ButtonRenderer.xml	✅Succeeded	View
xml/System.Windows.Forms/CheckBoxRenderer.xml	✅Succeeded	View
xml/System.Windows.Forms/Control.xml	✅Succeeded	View
xml/System.Windows.Forms/ControlStyles.xml	✅Succeeded	View
xml/System.Windows.Forms/Form.xml	✅Succeeded	View
xml/System.Windows.Forms/FormCornerPreference.xml	✅Succeeded	View
xml/System.Windows.Forms/GiveFeedbackEventArgs.xml	✅Succeeded	View
xml/System.Windows.Forms/RadioButtonRenderer.xml	✅Succeeded	View
xml/System.Windows.Forms/SystemColorMode.xml	✅Succeeded	View
xml/System.Windows.Forms/TaskDialog.xml	✅Succeeded	View
xml/System.Windows.Forms/ToolStrip.xml	✅Succeeded	View
xml/System.Windows.Forms/ToolStripItem.xml	✅Succeeded	View

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

learn-build-service-prod · 2024-09-21T04:54:41Z

Learn Build status updates of commit 6ba3897:

✅ Validation status: passed

File	Status	Preview URL
xml/System.Windows.Forms.Design.Behavior/BehaviorServiceAdornerCollection.xml	✅Succeeded	View
xml/System.Windows.Forms/AccessibleEvents.xml	✅Succeeded	View
xml/System.Windows.Forms/Application.xml	✅Succeeded	View
xml/System.Windows.Forms/ButtonBase.xml	✅Succeeded	View
xml/System.Windows.Forms/ButtonRenderer.xml	✅Succeeded	View
xml/System.Windows.Forms/CheckBoxRenderer.xml	✅Succeeded	View
xml/System.Windows.Forms/Control.xml	✅Succeeded	View
xml/System.Windows.Forms/ControlStyles.xml	✅Succeeded	View
xml/System.Windows.Forms/Form.xml	✅Succeeded	View
xml/System.Windows.Forms/FormCornerPreference.xml	✅Succeeded	View
xml/System.Windows.Forms/GiveFeedbackEventArgs.xml	✅Succeeded	View
xml/System.Windows.Forms/RadioButtonRenderer.xml	✅Succeeded	View
xml/System.Windows.Forms/SystemColorMode.xml	✅Succeeded	View
xml/System.Windows.Forms/TaskDialog.xml	✅Succeeded	View
xml/System.Windows.Forms/ToolStrip.xml	✅Succeeded	View
xml/System.Windows.Forms/ToolStripItem.xml	✅Succeeded	View

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

lonitra requested review from merriemcgaw and JeremyKuhne as code owners August 13, 2024 17:44

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 13, 2024

ghost added the area-WinForms Issues or PRs that relate to WinForms. label Aug 13, 2024

lonitra marked this pull request as draft August 13, 2024 18:05

carlossanlop reviewed Aug 16, 2024

View reviewed changes

carlossanlop requested a review from gewarren August 16, 2024 21:34

gewarren approved these changes Aug 20, 2024

View reviewed changes

lonitra and others added 3 commits September 19, 2024 12:09

Port WinForms API Docs for 9.0

17fda2c

Apply suggestions from code review

7dc3398

Co-authored-by: Carlos Sánchez López <[email protected]>

add docs for rc1 experimental apis

751cfe7

lonitra force-pushed the winformsdoc branch from 9665cc6 to 751cfe7 Compare September 19, 2024 19:58

fix toolstrip docs

2640776

Apply suggestions from code review

efccf59

Co-authored-by: Genevieve Warren <[email protected]>

Tanya-Solyanik reviewed Sep 19, 2024

View reviewed changes

xml/System.Windows.Forms/ToolStripItem.xml Outdated Show resolved Hide resolved

lonitra added 2 commits September 19, 2024 13:36

PR feedback

d63d343

Merge branch 'winformsdoc' of https://github.com/lonitra/dotnet-api-docs

639c2e7

into winformsdoc

lonitra marked this pull request as ready for review September 19, 2024 20:38

Apply suggestions from code review

baeea0d

Co-authored-by: Genevieve Warren <[email protected]>

carlossanlop approved these changes Sep 20, 2024

View reviewed changes

lonitra commented Sep 21, 2024

View reviewed changes

xml/System.Windows.Forms/TaskDialog.xml Outdated Show resolved Hide resolved

lonitra commented Sep 21, 2024

View reviewed changes

xml/System.Windows.Forms/TaskDialog.xml Outdated Show resolved Hide resolved

lonitra and others added 4 commits September 20, 2024 21:12

Apply suggestions from code review

2e67e63

Apply suggestions from code review

6d32f04

Co-authored-by: Carlos Sánchez López <[email protected]>

Apply suggestions from code review

6ba3897

Co-authored-by: Carlos Sánchez López <[email protected]>

PR feedback

927aeb8

carlossanlop merged commit f69b3f0 into dotnet:main Sep 21, 2024
3 checks passed

lonitra deleted the winformsdoc branch September 23, 2024 16:05

Port WinForms docs for 9.0 #10247

Port WinForms docs for 9.0 #10247

Uh oh!

Conversation

lonitra commented Aug 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

learn-build-service-prod bot commented Aug 13, 2024

✅ Validation status: passed

Uh oh!

carlossanlop left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

learn-build-service-prod bot commented Aug 19, 2024

✅ Validation status: passed

Uh oh!

learn-build-service-prod bot commented Aug 19, 2024

✅ Validation status: passed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lonitra commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gewarren commented Aug 27, 2024

Uh oh!

carlossanlop commented Sep 5, 2024

Uh oh!

lonitra commented Sep 5, 2024

Uh oh!

learn-build-service-prod bot commented Sep 19, 2024

❌ Validation status: errors

xml/System.Windows.Forms/ToolStrip.xml

Uh oh!

Uh oh!

learn-build-service-prod bot commented Sep 19, 2024

✅ Validation status: passed

Uh oh!

learn-build-service-prod bot commented Sep 19, 2024

✅ Validation status: passed

Uh oh!

learn-build-service-prod bot commented Sep 20, 2024

✅ Validation status: passed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

learn-build-service-prod bot commented Sep 21, 2024

✅ Validation status: passed

Uh oh!

learn-build-service-prod bot commented Sep 21, 2024

✅ Validation status: passed

Uh oh!

Uh oh!

Uh oh!

lonitra commented Aug 13, 2024 •

edited

Loading

lonitra commented Aug 27, 2024 •

edited

Loading