Update PipeWriter.xml #10260
Merged
Update PipeWriter.xml #10260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"request a new buffer" is not accurate. GetMemory(Int32) could return old buffer.
dotnet-policy-service
bot
added
the
community-contribution
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-io |
|
Learn Build status updates of commit 723f512: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
jozkee
reviewed
Aug 16, 2024
jozkee
reviewed
Aug 16, 2024
Co-authored-by: David Cantú <[email protected]>
|
Learn Build status updates of commit 51d7233: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
@jozkee Is this good to merge? |
jozkee
approved these changes
Aug 28, 2024
|
@gewarren yes, lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Regarding the original text "You must request a new buffer after calling Advance to continue writing more data;" --
"request a new buffer" part is not accurate. GetMemory(Int32) could return an old buffer.