Skip to content

Fix bad links - System namespace #10305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 26, 2024
Merged

Fix bad links - System namespace #10305

merged 3 commits into from
Aug 26, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Aug 23, 2024 •
edited
Loading

Contributes to #10311.

@ghost ghost added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Aug 23, 2024
gewarren
gewarren commented Aug 23, 2024
View reviewed changes
gewarren
gewarren commented Aug 23, 2024
View reviewed changes
gewarren
gewarren commented Aug 23, 2024
View reviewed changes
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@gewarren gewarren marked this pull request as ready for review August 24, 2024 00:38
@gewarren gewarren requested a review from a team as a code owner August 24, 2024 00:38
@gewarren gewarren enabled auto-merge (squash) August 24, 2024 00:46
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 5932322:

✅ Validation status: passed

File Status Preview URL Details
xml/System/AppDomainSetup.xml ✅Succeeded View
xml/System/Char.xml ✅Succeeded View
xml/System/Console.xml ✅Succeeded View
xml/System/DateTime.xml ✅Succeeded View
xml/System/Delegate.xml ✅Succeeded View
xml/System/GC.xml ✅Succeeded View
xml/System/GCMemoryInfo.xml ✅Succeeded View
xml/System/IAsyncResult.xml ✅Succeeded View
xml/System/IFormattable.xml ✅Succeeded View
xml/System/Object.xml ✅Succeeded View
xml/System/String.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren changed the title Fix bad links Fix bad links - System namespace Aug 24, 2024
BillWagner
BillWagner approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit 2da9674 into dotnet:main Aug 26, 2024
2 checks passed
@gewarren gewarren deleted the badlinks-1 branch September 29, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

@gewarren gewarren

Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gewarren @BillWagner