Skip to content

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Aug 24, 2024

Change Markdown links to see href links in non-Markdown sections.

(Hide whitespace changes.)

Contributes to #10311.

@gewarren gewarren requested review from merriemcgaw, JeremyKuhne and a team as code owners August 24, 2024 22:09
@ghost
Copy link

ghost commented Aug 24, 2024

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 24, 2024
@ghost
Copy link

ghost commented Aug 24, 2024

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

This comment was marked as outdated.

This comment was marked as outdated.

@gewarren gewarren added area-WPF Issues or PRs that relate to WPF or XAML. area-WinForms Issues or PRs that relate to WinForms. labels Aug 25, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/wpf-developers

Copy link

Learn Build status updates of commit 23f9501:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Windows.Annotations.Storage/AnnotationStore.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/MenuBase.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/Popup.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/StatusBar.xml ✅Succeeded View
xml/System.Windows.Controls.Primitives/TextBoxBase.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon.Primitives/RibbonContextualTabGroupsPanel.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon.Primitives/RibbonTabHeadersPanel.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon.Primitives/RibbonTitlePanel.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon.Primitives/StarLayoutInfo.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon/Ribbon.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon/RibbonApplicationMenu.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon/RibbonApplicationMenuItem.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon/RibbonApplicationSplitMenuItem.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon/RibbonButton.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon/RibbonCheckBox.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon/RibbonComboBox.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon/RibbonContextMenu.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon/RibbonContextualTabGroup.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon/RibbonControlGroup.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon/RibbonControlSizeDefinition.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon/RibbonGallery.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon/RibbonGalleryCategory.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon/RibbonGalleryItem.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon/RibbonGroup.xml ✅Succeeded View
xml/System.Windows.Controls.Ribbon/RibbonGroupSizeDefinition.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren enabled auto-merge (squash) August 26, 2024 20:24
@carlossanlop carlossanlop removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 5, 2024
Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I was wondering if these were caused by the porting tool, but it wouldn't be possible since they came from direct xml items: The see crefs were properly ported, so any unexpected markdown would be imported as is by the tool. In any case, the problem should've been caught by roslyn due to a malformed link that was added as markdown instead of xml.

@gewarren gewarren merged commit e1ba32a into dotnet:main Sep 5, 2024
3 checks passed
@gewarren gewarren deleted the badlinks-2 branch September 5, 2024 19:38
@gewarren
Copy link
Contributor Author

gewarren commented Sep 5, 2024

LGTM.

I was wondering if these were caused by the porting tool, but it wouldn't be possible since they came from direct xml items: The see crefs were properly ported, so any unexpected markdown would be imported as is by the tool. In any case, the problem should've been caught by roslyn due to a malformed link that was added as markdown instead of xml.

The really strange part is that they actually worked, in most cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-WinForms Issues or PRs that relate to WinForms. area-WPF Issues or PRs that relate to WPF or XAML.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants