Skip to content

Merge main into live #10340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 30, 2024
Merged

Merge main into live #10340

merged 15 commits into from
Aug 30, 2024

Conversation

dotnet-policy-service[bot]
Copy link
Contributor

Please don't squash-merge this PR.

gewarren and others added 15 commits August 29, 2024 10:19
@gewarren
fix build suggestions (#10333)
967ba24
@gewarren
Fix compilation error and modernize (#10334)
1975883
@eiriktsarpalis
Add missing System.Collections and System.Linq API docs.
e29c099
@gewarren
Fix bad links - various older namespaces (#10312)
4d7beb5
@eiriktsarpalis @carlossanlop
Update xml/System.Collections.Concurrent/ConcurrentDictionary`2.xml
f494426 
Co-authored-by: Carlos Sánchez López <[email protected]>
@eiriktsarpalis @carlossanlop
Update xml/System.Collections.Concurrent/ConcurrentDictionary`2.xml
fe7e634 
Co-authored-by: Carlos Sánchez López <[email protected]>
@eiriktsarpalis @carlossanlop
Update xml/System.Collections.Concurrent/ConcurrentDictionary`2.xml
4de9a99 
Co-authored-by: Carlos Sánchez López <[email protected]>
@eiriktsarpalis @carlossanlop
Update xml/System.Collections.Frozen/FrozenDictionary`2.xml
287545f 
Co-authored-by: Carlos Sánchez López <[email protected]>
@eiriktsarpalis @carlossanlop
Update xml/System.Collections.Frozen/FrozenDictionary`2.xml
2253dfb 
Co-authored-by: Carlos Sánchez López <[email protected]>
@eiriktsarpalis @carlossanlop
Update xml/System.Collections.Generic/OrderedDictionary`2+KeyCollecti…
7fe49fb 
…on.xml

Co-authored-by: Carlos Sánchez López <[email protected]>
@eiriktsarpalis @carlossanlop
Update xml/System.Collections.Frozen/FrozenDictionary`2.xml
6966d51 
Co-authored-by: Carlos Sánchez López <[email protected]>
@eiriktsarpalis @carlossanlop
Apply suggestions from code review
d39b6f5 
Co-authored-by: Carlos Sánchez López <[email protected]>
@eiriktsarpalis
Apply suggestions from code review
7ec7d86
@eiriktsarpalis
Merge pull request #10338 from eiriktsarpalis/doc-missing-apis
d789ea9 
Add missing System.Collections and System.Linq API docs.
@gewarren
Update default value (#9838)
1667ba9
@ghost ghost added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Aug 30, 2024
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 1667ba9:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml ⚠️Warning View Details
snippets/csharp/Microsoft.Win32.SafeHandles/SafeWaitHandle/Overview/Project.csproj ✅Succeeded
snippets/csharp/Microsoft.Win32.SafeHandles/SafeWaitHandle/Overview/sample.cs ✅Succeeded View
xml/Microsoft.Build.Tasks.Windows/GenerateTemporaryTargetAssembly.xml ✅Succeeded View
xml/Microsoft.JScript/ErrorType.xml ✅Succeeded View
xml/Microsoft.JScript/EvalErrorObject.xml ✅Succeeded View
xml/Microsoft.VisualBasic.Compatibility.VB6/BaseControlArray.xml ✅Succeeded View
xml/Microsoft.VisualBasic.Compatibility.VB6/DirListBox.xml ✅Succeeded View
xml/Microsoft.VisualBasic.Compatibility.VB6/DriveListBox.xml ✅Succeeded View
xml/Microsoft.VisualBasic.Compatibility.VB6/FileListBox.xml ✅Succeeded View
xml/Microsoft.VisualBasic/VbStrConv.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeWaitHandle.xml ✅Succeeded View
xml/System.CodeDom.Compiler/TempFileCollection.xml ✅Succeeded View
xml/System.Collections.Concurrent/ConcurrentDictionary`2.xml ✅Succeeded View
xml/System.Collections.Concurrent/ConcurrentDictionary2+AlternateLookup1.xml ✅Succeeded View
xml/System.Collections.Frozen/FrozenDictionary`2.xml ✅Succeeded View
xml/System.Collections.Frozen/FrozenDictionary2+AlternateLookup1.xml ✅Succeeded View
xml/System.Collections.Frozen/FrozenSet`1.xml ✅Succeeded View
xml/System.Collections.Generic/OrderedDictionary`2+KeyCollection.xml ✅Succeeded View
xml/System.Data.Common/DataAdapter.xml ✅Succeeded View
xml/System.Data.Common/DbBatchCommand.xml ✅Succeeded View
xml/System.Data.Common/DbCommand.xml ✅Succeeded View
xml/System.Data.Common/DbCommandBuilder.xml ✅Succeeded View
xml/System.Data.Common/DbParameter.xml ✅Succeeded View
xml/System.Data.Objects.DataClasses/EdmRelationshipNavigationPropertyAttribute.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.

xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'msdatasrc.DataSource.addDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'msdatasrc.DataSource.getDataMember(System.String,System.Guid@)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'msdatasrc.DataSource.getDataMemberCount'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'msdatasrc.DataSource.removeDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'ADODB.CursorLocationEnum'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'ADODB.LockTypeEnum'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'ADODB.Recordset'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'ADODB.ConnectModeEnum'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'msdatasrc.DataSource.getDataMemberName(System.Int32)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'msdatasrc.DataSource'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'ADODB.CursorTypeEnum'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'ADODB.CommandTypeEnum'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@dotnet-policy-service dotnet-policy-service bot merged commit 248c462 into live Aug 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. :octocat: auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gewarren @eiriktsarpalis