Skip to content

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Aug 30, 2024

Summary

Assembly.IsFullyTrusted and AppDomain.IsFullyTrusted properties return set values in .NET Core/5+. Make the docs call that out.

cc @dotnet/appmodel @jkotas

Copy link

Learn Build status updates of commit 435c2d1:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details
xml/System.Reflection/Assembly.xml ❌Error Details

  • Line 0, Column 0: [Error: ECMA2Yaml_File_LoadFailed] Failed to load 1 files, aborting...

xml/System.Reflection/Assembly.xml

  • Line 0, Column 0: [Error: ECMA2Yaml_InternalError]
Intenal Several Error: System.Xml.XmlException: The 'Docs' start tag on line 3905 position 8 does not match the end tag of 'value'. Line 3911, position 11.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String[] args)
   at System.Xml.XmlTextReaderImpl.ThrowTagMismatch(NodeData startTag)
   at System.Xml.XmlTextReaderImpl.ParseEndElement()
   at System.Xml.XmlTextReaderImpl.ParseElementContent()
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)
   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
   at System.Xml.Linq.XDocument.Parse(String text, LoadOptions options)
   at ECMA2Yaml.ECMALoader.LoadType(FileItem typeFile)
   at ECMA2Yaml.ECMALoader.LoadTypes(String basePath, Namespace ns)

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

This comment was marked as outdated.

Copy link

Learn Build status updates of commit 9204e7f:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Reflection.Emit/AssemblyBuilder.xml ✅Succeeded View
xml/System.Reflection/Assembly.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 5f8b34d:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Reflection.Emit/AssemblyBuilder.xml ✅Succeeded View
xml/System.Reflection/Assembly.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@elinor-fung elinor-fung changed the title Update Assembly HostContext, IsFullyTrusted, SecurityRuleSet properties for .NET Core/5+ behaviour Update Assembly.IsFullyTrusted and AssemblyBuilder.HostContext properties for .NET Core/5+ behaviour Aug 30, 2024
@jkotas
Copy link
Member

jkotas commented Aug 30, 2024

AppDomain.IsFullyTrusted is a sibling of this api. Should it get the same treatment?

Copy link

Learn Build status updates of commit ace30ef:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Reflection/Assembly.xml ✅Succeeded View
xml/System/AppDomain.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@elinor-fung elinor-fung changed the title Update Assembly.IsFullyTrusted and AssemblyBuilder.HostContext properties for .NET Core/5+ behaviour Update Assembly.IsFullyTrusted and AppDomain.IsFullyTrusted properties for .NET Core/5+ behaviour Sep 3, 2024
@elinor-fung elinor-fung merged commit 6403937 into dotnet:main Sep 3, 2024
3 checks passed
@elinor-fung elinor-fung deleted the assembly-props branch September 3, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants