Skip to content

Update ILogger documentation to clarify formatter behavior when using extension methods #10345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Update ILogger documentation to clarify formatter behavior when using extension methods #10345

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd3cbfb
Update `ILogger` documentation to clarify formatter behavior when usi…
enioluwas Aug 30, 2024
21a34ed
Move note to remarks
enioluwas Aug 30, 2024
f490ee1
Update based on feedback
enioluwas Aug 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xml/Microsoft.Extensions.Logging/ILogger.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Type Name="ILogger" FullName="Microsoft.Extensions.Logging.ILogger">
<Type Name="ILogger" FullName="Microsoft.Extensions.Logging.ILogger">
<TypeSignature Language="C#" Value="public interface ILogger" />
<TypeSignature Language="ILAsm" Value=".class public interface auto ansi abstract beforefieldinit ILogger" />
<TypeSignature Language="DocId" Value="T:Microsoft.Extensions.Logging.ILogger" />
Expand Down Expand Up @@ -143,7 +143,7 @@
<param name="exception">The exception related to this entry.</param>
<param name="formatter">Function to create a <see cref="T:System.String" /> message of the <paramref name="state" /> and <paramref name="exception" />.</param>
<summary>Writes a log entry.</summary>
<remarks>To be added.</remarks>
<remarks>The default <paramref name="formatter" /> provided by the logger extension methods doesn't include the <paramref name="exception" /> when formatting messages. It's essential for implementations of this method to decide how exceptions should be incorporated into the logs.</remarks>
</Docs>
</Member>
</Members>
Expand Down