Adding doc comments for ThemeMode, ThemeModeConverter introduced in PresentationFramework #10369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resentationFramework
ghost
added
the
|
Tagging subscribers to this area: @dotnet/wpf-developers |
dipeshmsft
requested review from
pchaurasia14,
singhashish-wpf,
gewarren,
adegeo and
harshit7962
|
Learn Build status updates of commit cc14260: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit a354091: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
gewarren
reviewed
Sep 7, 2024
|
Learn Build status updates of commit cecbea7: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit d797166: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit 8152895: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
@gewarren, I have made the required changes |
gewarren
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In .NET 9 Preview 7 we introduced a few new APIs ThemeMode, ThemeModeConverter, Application.ThemeMode and Window.ThemeMode. However, the doc comments for these new APIs were not generated yet. Hence adding these doc comments in this PR. Here is the link to the API Proposal : dotnet/wpf#8932