Skip to content

Conversation

buyaa-n
Copy link
Contributor

@buyaa-n buyaa-n commented Sep 6, 2024

Summary

Add remaining missing docs for System.ComponentModel from dotnet/runtime#105983

Fixes dotnet/runtime#105983

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-componentmodel

Copy link

Learn Build status updates of commit deb71c4:

✅ Validation status: passed

File Status Preview URL Details
xml/System.ComponentModel/ComponentResourceManager.xml ✅Succeeded View
xml/System.ComponentModel/CustomTypeDescriptor.xml ✅Succeeded View
xml/System.ComponentModel/TypeDescriptionProvider.xml ✅Succeeded View
xml/System.ComponentModel/TypeDescriptor.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@buyaa-n buyaa-n requested a review from steveharter September 6, 2024 23:31
Copy link
Contributor

@steveharter steveharter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment; thanks.

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. For the future, you don't need to include the type in the descriptions - it's added automatically.

Copy link

Learn Build status updates of commit f747404:

✅ Validation status: passed

File Status Preview URL Details
xml/System.ComponentModel/ComponentResourceManager.xml ✅Succeeded View
xml/System.ComponentModel/CustomTypeDescriptor.xml ✅Succeeded View
xml/System.ComponentModel/TypeDescriptionProvider.xml ✅Succeeded View
xml/System.ComponentModel/TypeDescriptor.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@buyaa-n buyaa-n merged commit 199c28d into dotnet:main Sep 10, 2024
3 checks passed
@buyaa-n buyaa-n deleted the componentmodel branch September 10, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port System.ComponentModel docs for .NET 9 APIs
3 participants