Skip to content

Conversation

muhammadzakriashahid
Copy link
Contributor

Summary

Describe your changes here.
i change the String type to string. Because of the rule ID IDE0049 Use language keywords instead of framework type names for type references.
Fixes #Issue_Number (if available)

@muhammadzakriashahid muhammadzakriashahid requested a review from a team as a code owner September 10, 2024 13:37
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 10, 2024
@ghost ghost added the area-System.Runtime label Sep 10, 2024
Copy link

Learn Build status updates of commit 5838cae:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System/String/Replace/string.replace1.cs ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@BillWagner
Copy link
Member

tag @gewarren

I know that our general guideline is to use string vs. String. Do you want to follow that same guideline for the System.String APIs?

@gewarren
Copy link
Contributor

tag @gewarren

I know that our general guideline is to use string vs. String. Do you want to follow that same guideline for the System.String APIs?

Yes, I don't see why not.

@gewarren
Copy link
Contributor

@muhammadzakriashahid Can you add a project file similar to https://github.com/dotnet/dotnet-api-docs/blob/main/snippets/csharp/System/Math/E/Project.csproj but for .net8.0 in the directory that contains the snippet? This is a newer requirement that we enforce whenever a code snippet is modified so we can ensure it compiles.

@muhammadzakriashahid
Copy link
Contributor Author

@dotnet-policy-service agree

Copy link

Learn Build status updates of commit fbe367c:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System/String/Replace/Project.csproj ✅Succeeded
snippets/csharp/System/String/Replace/replace1.cs ✅Succeeded View
snippets/csharp/System/String/Replace/replace2.cs ✅Succeeded View
snippets/csharp/System/String/Replace/string.replace1.cs ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@muhammadzakriashahid
Copy link
Contributor Author

haven't heard from you guys

@gewarren
Copy link
Contributor

Thanks @muhammadzakriashahid

@gewarren gewarren enabled auto-merge (squash) September 13, 2024 16:11
Copy link

Learn Build status updates of commit f9f16d7:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System/String/Replace/Program.cs ✅Succeeded
snippets/csharp/System/String/Replace/Project.csproj ✅Succeeded
snippets/csharp/System/String/Replace/replace1.cs ✅Succeeded View
snippets/csharp/System/String/Replace/replace2.cs ✅Succeeded View
snippets/csharp/System/String/Replace/string.replace1.cs ✅Succeeded View
snippets/csharp/System/String/Replace/stringreplace.cs ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit ec4f911 into dotnet:main Sep 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Runtime community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants