Skip to content

Conversation

tommcdon
Copy link
Member

@tommcdon tommcdon commented Sep 18, 2024

Summary

Documents the following missing items added during .NET 9

Summary Parameters TypeParameters ReturnValue API
Missing Missing NA NA M:System.Diagnostics.Debugger.BreakForUserUnhandledException(System.Exception)
Missing NA NA NA M:System.Diagnostics.DebuggerDisableUserUnhandledExceptionsAttribute.#ctor
Missing NA NA NA T:System.Diagnostics.DebuggerDisableUserUnhandledExceptionsAttribute

Fixes dotnet/runtime#105980

@tommcdon tommcdon requested a review from a team as a code owner September 18, 2024 05:25
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 18, 2024
Copy link
Contributor

Tagging subscribers to this area: @tommcdon

@tommcdon
Copy link
Member Author

@gewarren @carlossanlop

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

Learn Build status updates of commit 66866d2:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Diagnostics/DebuggerDisableUserUnhandledExceptionsAttribute.xml ⚠️Warning View Details
xml/System.Diagnostics/Debugger.xml ✅Succeeded View

xml/System.Diagnostics/DebuggerDisableUserUnhandledExceptionsAttribute.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'see' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@tommcdon
Copy link
Member Author

@gewarren I believe all feedback has been addressed. There is a new warning caused by the <see> tag in the summary section of the docs, but I see other <see> directives in other sections, so not sure what it is getting flagged. The preview notes look correct to me.

@tommcdon
Copy link
Member Author

@gewarren sorry for the additional ping, please let me know if there is any additional feedback on this PR

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see cref must be converted to xref in Markdown sections.

Copy link

Learn Build status updates of commit ad90489:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Diagnostics/Debugger.xml ✅Succeeded View
xml/System.Diagnostics/DebuggerDisableUserUnhandledExceptionsAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit d4d65ad into dotnet:main Sep 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Diagnostics community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port System.Diagnostics docs for .NET 9 APIs
2 participants