-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Purge use of RNGCryptoServiceProvider in examples #10476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adegeo Why does Snippets 5000 care about this file given that it's configured to ignore .cpp files? See
ExtensionsCodeTriggers: .cs;.vb;.fs;.xaml;.razor;.cshtml;.vbhtml;.sln;.csproj;.fsproj;.vbproj;.proj |
Learn Build status updates of commit ebc217a: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. For any questions, please:
|
Summary
The
RNGCryptoServiceProvider
class is obsolete in .NET. Instead of using this class directly, usingRandomNumberGenerator.Create
to get the appropriate implementation, which works for all .NETs (including .NET Framework).The only remaining use of
RNGCryptoServiceProvider
in examples is documentation forRNGCryptoServiceProvider
itself.Fixes #10329
Fixes #10011
Fixes #10018