Skip to content

ROPC fixes in C# files #10479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 1, 2024
Merged

ROPC fixes in C# files #10479

merged 3 commits into from
Oct 1, 2024

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Oct 1, 2024 •
edited
Loading

Replaces #10473.

Related to #10342.

  • Delete unneeded connection strings.
  • Delete some unsafe examples for older (System.Web) APIs.
  • Delete PII from DataSource names in connection strings.
  • Add project file where missing.

(Hide whitespace changes.)

@ghost ghost added the area-Infrastructure label Oct 1, 2024
@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
BillWagner
BillWagner approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, aside from the one build issue.

@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@gewarren gewarren enabled auto-merge (squash) October 1, 2024 19:18
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit b100afc:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Data/EntityKey/Overview/app.config ✅Succeeded
snippets/csharp/System.IdentityModel.Services/SessionAuthenticationModule/Overview/web.config.backup.1 ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.IdentityModel.Services/SignInRequestMessage/Overview/web.config.backup.1 ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System.IdentityModel.Services/WSFederationAuthenticationModule/Overview/web.config.backup.1 ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcCommand/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcCommand/CS/source.cs ✅Succeeded View
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcConnection.BeginTransaction/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcConnection.BeginTransaction/CS/source.cs ✅Succeeded View
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcConnection.BeginTransaction1/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcConnection.BeginTransaction1/CS/source.cs ✅Succeeded View
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcConnection.Close/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcConnection.Close/CS/source.cs ✅Succeeded View
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcConnection/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcConnection/CS/source.cs ✅Succeeded View
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.DeleteCommand/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.DeleteCommand/CS/source.cs ✅Succeeded View
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.InsertCommand/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.InsertCommand/CS/source.cs ✅Succeeded View
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.OdbcDataAdapter/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.OdbcDataAdapter/CS/source.cs ✅Succeeded View
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.OdbcDataAdapter1/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.OdbcDataAdapter1/CS/source.cs ✅Succeeded View
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.OdbcDataAdapter2/CS/Project.csproj ✅Succeeded
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.OdbcDataAdapter2/CS/source.cs ✅Succeeded View
snippets/csharp/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.OdbcDataAdapter3/CS/Project.csproj ✅Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit 912ede2 into dotnet:main Oct 1, 2024
3 checks passed
@gewarren gewarren deleted the ropc-fixes-chunk1 branch October 1, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@Rick-Anderson Rick-Anderson Awaiting requested review from Rick-Anderson

@David-Engel David-Engel Awaiting requested review from David-Engel David-Engel is a code owner

@JRahnama JRahnama Awaiting requested review from JRahnama

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

Assignees

@gewarren gewarren

Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gewarren @BillWagner