Skip to content

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Oct 1, 2024

Replaces #10473.
Related to #10342.

  • Delete unneeded connection strings.
  • Delete some unsafe examples for older (System.Web) APIs.
  • Delete PII from DataSource names in connection strings.
  • Add project file where missing.

(Hide whitespace changes.)

@gewarren gewarren requested a review from a team as a code owner October 1, 2024 17:43
@ghost ghost added the area-Infrastructure label Oct 1, 2024

This comment was marked as outdated.

@gewarren gewarren enabled auto-merge (squash) October 1, 2024 20:00

This comment was marked as outdated.

Copy link

Learn Build status updates of commit 8eba6e6:

✅ Validation status: passed

File Status Preview URL Details
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcCommand/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcCommand/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcConnection.BeginTransaction/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcConnection.BeginTransaction/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcConnection.BeginTransaction1/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcConnection.BeginTransaction1/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcConnection.Close/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcConnection.Close/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcConnection/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcConnection/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.DeleteCommand/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.DeleteCommand/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.InsertCommand/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.InsertCommand/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.OdbcDataAdapter/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.OdbcDataAdapter/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.OdbcDataAdapter1/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.OdbcDataAdapter1/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.OdbcDataAdapter2/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.OdbcDataAdapter2/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.OdbcDataAdapter3/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.OdbcDataAdapter3/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.SelectCommand/VB/Project.vbproj ✅Succeeded
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.SelectCommand/VB/source.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_ADO.NET/Classic WebData OdbcDataAdapter.UpdateCommand/VB/Project.vbproj ✅Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren requested a review from BillWagner October 1, 2024 20:43
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Impressive to have all this done and under our CI system. 🎆

Let's :shipit:

@gewarren gewarren merged commit 517862c into dotnet:main Oct 1, 2024
3 checks passed
@gewarren gewarren deleted the ropc-fixes-chunk2 branch October 1, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants